SSL test: Don't depend on property value in test#16346
Merged
Merged
Conversation
Motivation: We should not depend on modify a system property in a test when running tests concurrently as it might fail due races. Modifications: Just override the method in SslMasterKeyHandler and not depend on the property at all. Result: Less flaky tests
Member
Author
|
This is needed as we now run tests concurrently: f0fe411 |
chrisvest
approved these changes
Feb 24, 2026
Contributor
|
Could not create auto-port PR. |
Contributor
|
Could not create auto-port PR. |
normanmaurer
added a commit
that referenced
this pull request
Feb 25, 2026
Motivation: We should not depend on modify a system property in a test when running tests concurrently as it might fail due races. Modifications: Just override the method in SslMasterKeyHandler and not depend on the property at all. Result: Less flaky tests
normanmaurer
added a commit
that referenced
this pull request
Feb 25, 2026
Motivation: We should not depend on modify a system property in a test when running tests concurrently as it might fail due races. Modifications: Just override the method in SslMasterKeyHandler and not depend on the property at all. Result: Less flaky tests
chrisvest
pushed a commit
that referenced
this pull request
Feb 25, 2026
Motivation: We should not depend on modify a system property in a test when running tests concurrently as it might fail due races. Modifications: Just override the method in SslMasterKeyHandler and not depend on the property at all. Result: Less flaky tests
chrisvest
pushed a commit
that referenced
this pull request
Feb 26, 2026
Motivation: We should not depend on modify a system property in a test when running tests concurrently as it might fail due races. Modifications: Just override the method in SslMasterKeyHandler and not depend on the property at all. Result: Less flaky tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We should not depend on modify a system property in a test when running tests concurrently as it might fail due races.
Modifications:
Just override the method in SslMasterKeyHandler and not depend on the property at all.
Result:
Less flaky tests