Avoid buffer duplication in AdaptiveByteBuf.setBytes (#15728) #15731
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The setBytes methods are mutating methods, and therefor not thread-safe. The pooling allocator do not protect the position of its internal NIO buffer in these methods, which means it does not call duplicate on the buffer before using it. The adaptive allocator can make the same optimization. Modification: Remove ByteBuffer.duplicate calls from the setBytes methods of the AdaptiveByteBuf. Result: No more unnecessary ByteBuffer allocation when calling these methods, so the performance should now be on par with the pooling allocator. Fixes #15723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The setBytes methods are mutating methods, and therefor not thread-safe. The pooling allocator do not protect the position of its internal NIO buffer in these methods, which means it does not call duplicate on the buffer before using it. The adaptive allocator can make the same optimization.
Modification:
Remove ByteBuffer.duplicate calls from the setBytes methods of the AdaptiveByteBuf.
Result:
No more unnecessary ByteBuffer allocation when calling these methods, so the performance should now be on par with the pooling allocator.
Fixes #15723