Adaptive: Only use ThreadLocal if called from FastThreadLocalThread i…#14656
Merged
normanmaurer merged 1 commit into4.1from Jan 13, 2025
Merged
Adaptive: Only use ThreadLocal if called from FastThreadLocalThread i…#14656normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
#14625) …n case of temporary byte[] allocation Motivation: We should only use ThreadLocal's if we are sure we are using a FastThreadLocalThread. This ensures the allocator and buffers are Virtual Thread friendly Modifications: Check instance of Thread and only use ThreadLocal if its an instance of FastThreadLocalThread Result: Fixes #14609
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…… (#14625)
…n case of temporary byte[] allocation
Motivation:
We should only use ThreadLocal's if we are sure we are using a FastThreadLocalThread. This ensures the allocator and buffers are Virtual Thread friendly
Modifications:
Check instance of Thread and only use ThreadLocal if its an instance of FastThreadLocalThread
Result:
Fixes #14609