SslHandler: Ensure buffers are never leaked when wrap(...) produce SS…#14647
Merged
normanmaurer merged 1 commit into4.1from Jan 13, 2025
Merged
SslHandler: Ensure buffers are never leaked when wrap(...) produce SS…#14647normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
…LException Motivation: After we removed the ByteBuf from the pendingUnencryptedWrites queue we need to ensure we will always release ByteBuf even in the case of wrapMultiple(...) or wrap(...) throwing a SSLException. Modifications: - Ensure we release the ByteBuf when a SSLException is thrown before rethrowing it. Result: Fixes #14644
Member
Author
|
I am surprised that nobody reported this before... |
Member
Author
|
I am currently still trying to figure out how to best write a test case for that which is kind of hard. I think we should merge this PR anyway |
chrisvest
approved these changes
Jan 10, 2025
bryce-anderson
approved these changes
Jan 13, 2025
daschl
approved these changes
Jan 13, 2025
normanmaurer
added a commit
that referenced
this pull request
Jan 13, 2025
#14647) …LException Motivation: After we removed the ByteBuf from the pendingUnencryptedWrites queue we need to ensure we will always release ByteBuf even in the case of wrapMultiple(...) or wrap(...) throwing a SSLException. Modifications: - Ensure we release the ByteBuf when a SSLException is thrown before rethrowing it. Result: Fixes #14644
normanmaurer
added a commit
that referenced
this pull request
Jan 13, 2025
#14651) …… (#14647) …LException Motivation: After we removed the ByteBuf from the pendingUnencryptedWrites queue we need to ensure we will always release ByteBuf even in the case of wrapMultiple(...) or wrap(...) throwing a SSLException. Modifications: - Ensure we release the ByteBuf when a SSLException is thrown before rethrowing it. Result: Fixes #14644
normanmaurer
added a commit
that referenced
this pull request
Jan 13, 2025
#14647) …LException Motivation: After we removed the ByteBuf from the pendingUnencryptedWrites queue we need to ensure we will always release ByteBuf even in the case of wrapMultiple(...) or wrap(...) throwing a SSLException. Modifications: - Ensure we release the ByteBuf when a SSLException is thrown before rethrowing it. Result: Fixes #14644
normanmaurer
added a commit
that referenced
this pull request
Jan 13, 2025
#14652) …… (#14647) …LException Motivation: After we removed the ByteBuf from the pendingUnencryptedWrites queue we need to ensure we will always release ByteBuf even in the case of wrapMultiple(...) or wrap(...) throwing a SSLException. Modifications: - Ensure we release the ByteBuf when a SSLException is thrown before rethrowing it. Result: Fixes #14644
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…LException
Motivation:
After we removed the ByteBuf from the pendingUnencryptedWrites queue we need to ensure we will always release ByteBuf even in the case of wrapMultiple(...) or wrap(...) throwing a SSLException.
Modifications:
Result:
Fixes #14644