Skip to content

adjust continuation frame header length#14245

Merged
normanmaurer merged 5 commits into
netty:4.1from
CLFutureX:4.1_adjust_continuation_frame_header_length
Sep 2, 2024
Merged

adjust continuation frame header length#14245
normanmaurer merged 5 commits into
netty:4.1from
CLFutureX:4.1_adjust_continuation_frame_header_length

Conversation

@CLFutureX

@CLFutureX CLFutureX commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

Motivation:

Padding was removed from CONTINUATION frame in http2-spec,
at the same time , the continuation frame header should be adjusted,
which can also to reduce the allocation of bytes.

@CLFutureX CLFutureX closed this Aug 22, 2024
@CLFutureX CLFutureX reopened this Aug 22, 2024
@CLFutureX CLFutureX requested a review from normanmaurer August 23, 2024 15:17
@normanmaurer

Copy link
Copy Markdown
Member

I would argue we should ignore the Revapi failure here as at worse it will just use the old value and so allocate 1 extra byte until things are re-compiled. @chrisvest WDYT ?

@chrisvest

Copy link
Copy Markdown
Member

@normanmaurer I agree. Revapi is flagging it because such a change could be problematic, but this case should be fine as you say.
@CLFutureX Just add a difference to be ignored in the top-level pom.xml file: https://github.com/netty/netty/blob/4.1/pom.xml#L1297

@CLFutureX

Copy link
Copy Markdown
Contributor Author

Padding was removed from CONTINUATION frame in http2-spec,

@normanmaurer I agree. Revapi is flagging it because such a change could be problematic, but this case should be fine as you say. @CLFutureX Just add a difference to be ignored in the top-level pom.xml file: https://github.com/netty/netty/blob/4.1/pom.xml#L1297

okay,i fix it

@normanmaurer normanmaurer merged commit c0fdb8e into netty:4.1 Sep 2, 2024
normanmaurer pushed a commit that referenced this pull request Sep 2, 2024
Motivation:

Padding was removed from CONTINUATION frame in http2-spec, 
at the same time, the continuation frame header should be adjusted,
which can also to reduce the allocation of bytes.

Modifications:

Adjust number of bytes

Result:

Reduce num of bytes that are allocated
normanmaurer pushed a commit that referenced this pull request Sep 2, 2024
Motivation:

Padding was removed from CONTINUATION frame in http2-spec,
at the same time, the continuation frame header should be adjusted,
which can also to reduce the allocation of bytes.

Modifications:

Adjust number of bytes

Result:

Reduce num of bytes that are allocated
@normanmaurer

Copy link
Copy Markdown
Member

@CLFutureX Thanks a lot!

@normanmaurer normanmaurer added this to the 4.1.113.Final milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants