Fix OSGi import package version for net.minidev.asm.#180
Merged
hezhangjian merged 1 commit intonetplex:masterfrom Mar 12, 2024
Merged
Fix OSGi import package version for net.minidev.asm.#180hezhangjian merged 1 commit intonetplex:masterfrom
hezhangjian merged 1 commit intonetplex:masterfrom
Conversation
Collaborator
|
Hi, @msqr Thanks for your contribution. But I think it will be better to specify the dependencies instead of using |
Contributor
Author
|
I believe using a wildcard Another approach would be to limit the wildcard to the specific packages, like <Import-Package>
net.minidev.asm;version="1.0",
net.minidev.json.*
</Import-Package>That produces this That is a bit more explicit with the package version ranges, but that is not normally how I see OSGi bundles produced: bundles import the packages they themselves export, but without a version range. |
Collaborator
|
@msqr Thanks for your explanation. |
hezhangjian
approved these changes
Mar 12, 2024
Collaborator
|
@msqr tell me if your want a new release. |
Contributor
Author
|
A new release would be very helpful, yes. Thanks! |
github-merge-queue bot
referenced
this pull request
in camunda/camunda
Mar 28, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [net.minidev:json-smart](https://urielch.github.io/) ([source](https://togithub.com/netplex/json-smart-v2)) | `2.4.10` -> `2.5.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>netplex/json-smart-v2 (net.minidev:json-smart)</summary> ### [`v2.5.1`](https://togithub.com/netplex/json-smart-v2/releases/tag/2.5.1): V 2.5.1 [Compare Source](https://togithub.com/netplex/json-smart-v2/compare/2.5.0...2.5.1) #### What's Changed - Bump junit.version from 5.9.3 to 5.10.0 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/158](https://togithub.com/netplex/json-smart-v2/pull/158) - Bump junit.version from 5.9.3 to 5.10.0 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/157](https://togithub.com/netplex/json-smart-v2/pull/157) - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.5.0 to 3.6.2 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/166](https://togithub.com/netplex/json-smart-v2/pull/166) - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.5.0 to 3.6.2 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/165](https://togithub.com/netplex/json-smart-v2/pull/165) - Bump junit.version from 5.10.0 to 5.10.1 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/164](https://togithub.com/netplex/json-smart-v2/pull/164) - Bump junit.version from 5.10.0 to 5.10.1 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/163](https://togithub.com/netplex/json-smart-v2/pull/163) - chore: Update github id from Shoothzj to shoothzj by [@​shoothzj](https://togithub.com/shoothzj) in [https://github.com/netplex/json-smart-v2/pull/168](https://togithub.com/netplex/json-smart-v2/pull/168) - Bump asm version from 9.3 to 9.6 by [@​shoothzj](https://togithub.com/shoothzj) in [https://github.com/netplex/json-smart-v2/pull/167](https://togithub.com/netplex/json-smart-v2/pull/167) - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.6.2 to 3.6.3 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/169](https://togithub.com/netplex/json-smart-v2/pull/169) - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.6.2 to 3.6.3 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/170](https://togithub.com/netplex/json-smart-v2/pull/170) - Bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 to 3.12.0 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/172](https://togithub.com/netplex/json-smart-v2/pull/172) - Bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 to 3.12.0 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/171](https://togithub.com/netplex/json-smart-v2/pull/171) - Bump org.apache.maven.plugins:maven-compiler-plugin from 3.12.0 to 3.12.1 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/174](https://togithub.com/netplex/json-smart-v2/pull/174) - Bump org.apache.maven.plugins:maven-compiler-plugin from 3.12.0 to 3.12.1 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/173](https://togithub.com/netplex/json-smart-v2/pull/173) - Fix OSGi import package version for net.minidev.asm. by [@​msqr](https://togithub.com/msqr) in [https://github.com/netplex/json-smart-v2/pull/180](https://togithub.com/netplex/json-smart-v2/pull/180) - Bump junit.version from 5.10.1 to 5.10.2 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/179](https://togithub.com/netplex/json-smart-v2/pull/179) - Bump junit.version from 5.10.1 to 5.10.2 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/178](https://togithub.com/netplex/json-smart-v2/pull/178) - Bump version from 2.5.0 to 2.5.1 by [@​shoothzj](https://togithub.com/shoothzj) in [https://github.com/netplex/json-smart-v2/pull/181](https://togithub.com/netplex/json-smart-v2/pull/181) - docs: add change log for version 2.5.1 by [@​shoothzj](https://togithub.com/shoothzj) in [https://github.com/netplex/json-smart-v2/pull/182](https://togithub.com/netplex/json-smart-v2/pull/182) - Update 2024 by [@​UrielCh](https://togithub.com/UrielCh) in [https://github.com/netplex/json-smart-v2/pull/183](https://togithub.com/netplex/json-smart-v2/pull/183) - add somme doc to remove deployement warnings by [@​UrielCh](https://togithub.com/UrielCh) in [https://github.com/netplex/json-smart-v2/pull/184](https://togithub.com/netplex/json-smart-v2/pull/184) #### New Contributors - [@​msqr](https://togithub.com/msqr) made their first contribution in [https://github.com/netplex/json-smart-v2/pull/180](https://togithub.com/netplex/json-smart-v2/pull/180) **Full Changelog**: netplex/json-smart-v2@2.5.0...2.5.1 ### [`v2.5.0`](https://togithub.com/netplex/json-smart-v2/releases/tag/2.5.0): V 2.5.0 [Compare Source](https://togithub.com/netplex/json-smart-v2/compare/2.4.11...2.5.0) #### What's Changed - Bump maven-bundle-plugin from 5.1.8 to 5.1.9 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/148](https://togithub.com/netplex/json-smart-v2/pull/148) - Bump maven-bundle-plugin from 5.1.8 to 5.1.9 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/149](https://togithub.com/netplex/json-smart-v2/pull/149) - Bump maven-source-plugin from 3.2.1 to 3.3.0 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/151](https://togithub.com/netplex/json-smart-v2/pull/151) - Bump maven-source-plugin from 3.2.1 to 3.3.0 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/150](https://togithub.com/netplex/json-smart-v2/pull/150) - Bump maven-release-plugin from 3.0.0 to 3.0.1 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/152](https://togithub.com/netplex/json-smart-v2/pull/152) - Bump maven-release-plugin from 3.0.0 to 3.0.1 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/153](https://togithub.com/netplex/json-smart-v2/pull/153) - add flag to drop the limit of json depth by [@​Shoothzj](https://togithub.com/Shoothzj) in [https://github.com/netplex/json-smart-v2/pull/156](https://togithub.com/netplex/json-smart-v2/pull/156) **Full Changelog**: netplex/json-smart-v2@2.4.11...2.5.0 ### [`v2.4.11`](https://togithub.com/netplex/json-smart-v2/releases/tag/2.4.11): V 2.4.11 [Compare Source](https://togithub.com/netplex/json-smart-v2/compare/2.4.10...2.4.11) ##### *V 2.4.11* (2023-05-18) - Fix error in isWritable in accessor-smart. [PR 147](https://togithub.com/netplex/json-smart-v2/pull/147) - Update json-smart dependency to use accessor-smart:2.4.11 #### What's Changed - Bump maven-release-plugin from 3.0.0-M7 to 3.0.0 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/135](https://togithub.com/netplex/json-smart-v2/pull/135) - Bump maven-release-plugin from 3.0.0-M7 to 3.0.0 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/136](https://togithub.com/netplex/json-smart-v2/pull/136) - Bump maven-resources-plugin from 3.3.0 to 3.3.1 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/138](https://togithub.com/netplex/json-smart-v2/pull/138) - Bump maven-resources-plugin from 3.3.0 to 3.3.1 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/139](https://togithub.com/netplex/json-smart-v2/pull/139) - Fix the grammar in the Readme by [@​wirelessben](https://togithub.com/wirelessben) in [https://github.com/netplex/json-smart-v2/pull/140](https://togithub.com/netplex/json-smart-v2/pull/140) - Bump junit.version from 5.9.2 to 5.9.3 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/144](https://togithub.com/netplex/json-smart-v2/pull/144) - Bump junit.version from 5.9.2 to 5.9.3 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/143](https://togithub.com/netplex/json-smart-v2/pull/143) - Fix CVE from being reported against accessors-smart by [@​Grimoren](https://togithub.com/Grimoren) in [https://github.com/netplex/json-smart-v2/pull/142](https://togithub.com/netplex/json-smart-v2/pull/142) - Bump maven-gpg-plugin from 3.0.1 to 3.1.0 in /json-smart-action by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/146](https://togithub.com/netplex/json-smart-v2/pull/146) - Bump maven-gpg-plugin from 3.0.1 to 3.1.0 in /json-smart by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/netplex/json-smart-v2/pull/145](https://togithub.com/netplex/json-smart-v2/pull/145) - Fix isWritable method by [@​harikrishna553](https://togithub.com/harikrishna553) in [https://github.com/netplex/json-smart-v2/pull/147](https://togithub.com/netplex/json-smart-v2/pull/147) #### New Contributors - [@​wirelessben](https://togithub.com/wirelessben) made their first contribution in [https://github.com/netplex/json-smart-v2/pull/140](https://togithub.com/netplex/json-smart-v2/pull/140) - [@​Grimoren](https://togithub.com/Grimoren) made their first contribution in [https://github.com/netplex/json-smart-v2/pull/142](https://togithub.com/netplex/json-smart-v2/pull/142) - [@​harikrishna553](https://togithub.com/harikrishna553) made their first contribution in [https://github.com/netplex/json-smart-v2/pull/147](https://togithub.com/netplex/json-smart-v2/pull/147) **Full Changelog**: netplex/json-smart-v2@2.4.10...2.4.11 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 6am every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
|
I do not believe this change to be correct. |
Contributor
Author
|
Thanks @croister I hadn't noticed that artifact name change. Indeed |
|
I suggest that the commit is reverted and a new release is made. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to deploy json-smart in an OSGi runtime, and found that it imports the
net.minidev.asmpackage with a version range of[2.5,3), taken from this snippet ofMANIFEST.MF:However the net.minidev:asm JAR is up to version 1.0.2. I was able to load both json-smart and the asm bundles in my OSGi runtime by tweaking the import package configuration in the POM, to explicitly define the import version of
net.minidev.asmas1.0. That produces the followingMANIFEST.MFresult: