feat: support header matching in edge functions#361
Merged
eduardoboucas merged 3 commits intomainfrom Jul 18, 2025
Merged
Conversation
pieh
reviewed
Jul 18, 2025
Comment on lines
+134
to
+142
| const requestHeaderValue = req.headers.get(headerName)?.split(', ').join(',') | ||
|
|
||
| if (headerMatch?.matcher === 'exists') { | ||
| return Boolean(requestHeaderValue) | ||
| } | ||
|
|
||
| if (headerMatch?.matcher === 'missing') { | ||
| return !requestHeaderValue | ||
| } |
Contributor
There was a problem hiding this comment.
Will this work as expected if header has empty string? I'm not sure how useful looking into such case is (do empty string header value happen in practice?), but:
Boolean((new Headers({ 'test': ''})).get('test').split(',').join(','))
would be false, so it would not pass exists check for test header and would pass missing check, but I dunno if this would be a bug or not
pieh
reviewed
Jul 18, 2025
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
pieh
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/netlify/issue/RUN-1783/add-edge-function-matching-by-header-to-primitives-monorepo.