fix(edge): note when stopped so we can kill process in early init#313
Merged
fix(edge): note when stopped so we can kill process in early init#313
Conversation
This is to address the edge case surfaced by the (Astro integration PR)[withastro/astro#13768] wherein the edge function Deno server won't be closed if the .stop() comes in very soon after the init. The issue is that .stop() can be called before denoBridge.runInBackground has finished resolving (but before we've waited for the server to start), and in that case we will never know it needed to be stopped.
JakeChampion
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address the edge case surfaced by the Astro integration PR wherein the edge function Deno server won't be closed if the .stop() comes in very soon after the init.
The issue is that .stop() can be called before denoBridge.runInBackground has finished resolving (but before we've waited for the server to start), and in that case we will never know it needed to be stopped.