feat: add support for edge functions by eduardoboucas · Pull Request #233 · netlify/primitives

eduardoboucas · 2025-05-28T12:48:42Z

No description provided.

eduardoboucas · 2025-05-28T12:49:43Z

packages/dev-utils/src/templates/function-error.html

@@ -0,0 +1,303 @@
+<!DOCTYPE html>


Copied as is from the CLI.

eduardoboucas · 2025-05-28T12:50:25Z

packages/dev-utils/src/lib/errors.ts

+import { fileURLToPath } from 'node:url'
+
+const templatesPath = dirname(fileURLToPath(import.meta.url))
+const functionErrorTemplatePath = resolve(templatesPath, '../src/templates/function-error.html')


This file was copied from the CLI. The only change I made was to hardcode the path to the function error template, as opposed to accepting it as an argument of renderFunctionErrorPage, as I didn't see a reason for that.

eduardoboucas · 2025-05-28T12:51:01Z

packages/dev-utils/src/server/http_server.ts

  }

  async start(port = 0) {
+    if (this.url) {


Small change to make it possible to call start() multiple times without us starting multiple servers.

eduardoboucas · 2025-05-28T12:51:14Z

packages/dev/src/lib/request_id.ts

@@ -0,0 +1,3 @@
+import { ulid } from 'ulid'


Copied as is from the CLI.

eduardoboucas · 2025-05-28T12:52:55Z

packages/dev/src/main.ts


  private async handleInEphemeralDirectory(request: Request, destPath: string) {
-    // Functions
-    const userFunctionsPath =


I moved the initialisation of the handlers to the start() method so that we only have one instance of each handler per NetlifyDev instance.

eduardoboucas · 2025-05-28T12:55:04Z

packages/dev/src/main.ts

+      }
+
+      this.#edgeFunctionsHandler = new EdgeFunctionsHandler({
+        bootstrapURL: 'https://edge.netlify.com/bootstrap/index-combined.ts',


It doesn't make sense to have this here. This needs to point to a specific version of the bootstrap, which is what the existing @netlify/edge-functions package (published from the bootstrap repo) does. We'll need to figure out a different setup here. For consistency, I've used @netlify/edge-functions for the new package in this monorepo, so perhaps we need to start publishing something like @netlify/edge-functions-bootstrap from the bootstrap repo and we add it as a dependency here.

packages/dev/src/main.ts

eduardoboucas · 2025-05-28T12:57:18Z

packages/edge-functions/src/lib/config.ts

@@ -0,0 +1,68 @@
+type Cache = 'off' | 'manual'


This file was copied as is from the bootstrap repo.

packages/dev/src/main.ts

eduardoboucas · 2025-05-29T11:07:45Z

.github/workflows/test.yaml

      matrix:
        os: [ubuntu-latest, macOS-latest, windows-latest]
        node-version: ['*']
-        deno-version: ['v1.37.0', 'v1.44.4']


I don't think we need to test with multiple versions of Deno.

packages/dev/src/main.ts

eduardoboucas · 2025-05-29T11:10:26Z

packages/dev/src/main.ts

+    }
+
+    if (this.#features.headers) {
+      this.#headersHandler = new HeadersHandler({


@serhalp FYI, I moved the initialisation of all the handlers here, so I did the same to HeadersHandler.

Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>

eduardoboucas · 2025-05-30T13:00:40Z

eslint.config.js


+const packagesPath = path.join(__dirname, 'packages')
+const packages = await fs.readdir(packagesPath)
+const packageIgnores = packages.map((name) => includeIgnoreFile(path.resolve(packagesPath, name, '.gitignore')))


This is awkward. As I mentioned to @serhalp, I think we should have each package defining its own lint step with its own ignore rules, etc.

eduardoboucas · 2025-05-30T13:01:21Z

packages/dev-utils/src/lib/geo-location.ts

+
+export type Geolocation = Context['geo']
+
+export const mockLocation: Geolocation = {


We should incorporate the CLI logic that uses https://netlifind.netlify.app/ to provide a real geo-location object.

serhalp · 2025-05-30T15:43:20Z

packages/edge-functions/dev/node/main.ts


    try {
-      await denoBridge.runInBackground(['run', ...denoFlags, denoRunPath, JSON.stringify(runOptions)], processRef, {
+      await denoBridge.runInBackground(['eval', ...denoFlags, script], processRef, {


from https://netlify.slack.com/archives/C0359548J07/p1748542712027619?thread_ts=1748532679.718369&cid=C0359548J07 it seems like this approach didn't work?

packages/edge-functions/dev/node/main.test.ts

serhalp · 2025-05-30T15:47:04Z

packages/edge-functions/src/version.ts

+    // Releasing version 1.2.3 of the `@netlify/edge-functions` module will
+    // make release-please create a GitHub release and corresponding tag of
+    // `v1.2.3`. Because the `edge` Netlify site is configured to build all
+    // branches, the tag will generate a `v1-2-3--edge.netlify.com` URL,
+    // which serves the bootstrap for this version. We're computing that
+    // URL here.
+    const branch = `v${version.split('.').join('-')}`


Never mind, I hadn't seen https://github.com/netlify/edge-functions-bootstrap/pull/423

Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>

- move non-temporary config out of `eslint_temporary_suppressions` - configure `node-builtins` rule properly

The new eslint setup was merged after most of the work on this PR was done.

eduardoboucas added 2 commits May 28, 2025 13:47

feat: add support for edge functions

dee6a4e

chore: update lock file

f355662

eduardoboucas commented May 28, 2025

View reviewed changes

packages/dev/src/lib/request_id.ts

@@ -0,0 +1,3 @@

import { ulid } from 'ulid'

Copy link

Member Author

eduardoboucas May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied as is from the CLI.

eduardoboucas commented May 28, 2025

View reviewed changes

packages/dev/src/main.ts Show resolved Hide resolved

chore: remove unused types

d44fc4a

eduardoboucas commented May 28, 2025

View reviewed changes

chore: remove unused file

36e4a6f

pieh reviewed May 28, 2025

View reviewed changes

packages/dev/src/main.ts Outdated Show resolved Hide resolved

eduardoboucas added 8 commits May 29, 2025 10:08

feat: more things

e13c397

chore: remove .only

ec76a9c

refactor: rename prop

b9bd3c7

Merge branch 'main' into feat/edge-functions

f71e5dc

refactor: handle merge

16c1775

fix: use serverAddress prop

e3b7ad2

chore: update Deno version in CI

37b0c7d

fix: add dep

c99bc2e

eduardoboucas commented May 29, 2025

View reviewed changes

packages/dev/src/main.ts Show resolved Hide resolved

eduardoboucas commented May 29, 2025

View reviewed changes

eduardoboucas added 2 commits May 29, 2025 12:35

refactor: update bootstrap URL

658669d

feat: add dynamic bootstrap URL

4ce2b23

eduardoboucas marked this pull request as ready for review May 29, 2025 13:30

eduardoboucas requested review from a team as code owners May 29, 2025 13:30

refactor: fix lint issues

733dc2d

eduardoboucas and others added 9 commits May 30, 2025 12:29

Merge branch 'main' into feat/edge-functions

803683c

chore: fix test

0d019a6

Apply suggestions from code review

15453ed

Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>

chore: fix formatting

96857af

fix: fix tests

c45133d

chore: remove unused file

df1dd89

chore: add comment

e17cf75

refactor: conditionally start HTTP server

2e788ec

refactor: rename variables

2130ba8

eduardoboucas commented May 30, 2025

View reviewed changes

serhalp previously approved these changes May 30, 2025

View reviewed changes

Update packages/edge-functions/dev/node/main.test.ts

896dadf

Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>

eduardoboucas dismissed serhalp’s stale review via 896dadf May 30, 2025 15:50

eduardoboucas and others added 7 commits May 30, 2025 16:51

Merge branch 'main' into feat/edge-functions

d5a4efc

fix(deps): update lockfile

ce68363

build: improve eslint config

9695a25

- move non-temporary config out of `eslint_temporary_suppressions` - configure `node-builtins` rule properly

refactor: fix lint errors

c4debdc

build: add new suppressions

db092db

The new eslint setup was merged after most of the work on this PR was done.

chore(deps): bump @netlify/types in packages/edge-functions

5ebbe2b

ci: add missing build step to lint job

b137e73

serhalp previously approved these changes May 30, 2025

View reviewed changes

chore: update lockfile

f7a4a58

serhalp dismissed their stale review via f7a4a58 May 30, 2025 17:27

serhalp approved these changes May 30, 2025

View reviewed changes

serhalp merged commit c80d77d into main May 30, 2025
7 checks passed

serhalp deleted the feat/edge-functions branch May 30, 2025 17:40

token-generator-app bot mentioned this pull request May 30, 2025

chore: release main #238

Merged

token-generator-app bot mentioned this pull request Jul 29, 2025

chore: release main #402

Merged

pieh mentioned this pull request Oct 13, 2025

feat!: split functions package #475

Merged


		export type Geolocation = Context['geo']

		export const mockLocation: Geolocation = {

Conversation

eduardoboucas commented May 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants