fix: add after each app.close() to e2e template#2313
Merged
kamilmysliwiec merged 2 commits intoMar 30, 2026
Conversation
| await app.init(); | ||
| }); | ||
|
|
||
| afterEach(async () => { |
Member
There was a problem hiding this comment.
could you move it to the end of the describe block?
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The E2E template generated by the NestJS CLI initializes the application in a beforeEach hook but never closes it. The missing
app.close()call in anafterEach/afterAllhook prevents Jest from exiting cleanly, causing the test suite to hang indefinitely on CI.Issue Number: nestjs/nest-cli#3293
What is the new behavior?
An
afterEachhook callingawait app.close()to the generated E2E test template.Does this PR introduce a breaking change?
Other information