fix(cli): resolve Windows path separator bug in plugin loader#3458
Merged
kamilmysliwiec merged 1 commit intoJun 8, 2026
Merged
Conversation
On Windows, path.join(item, PLUGIN_ENTRY_FILENAME) produces backslashes
(e.g. '@nestjs/graphql\plugin'), which causes require.resolve to fail.
Use forward slash ('/') instead, which works
correctly on all platforms including Windows.
Fixes #N/A
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
On Windows,
path.join(item, PLUGIN_ENTRY_FILENAME)produces backslashes (e.g.@nestjs/graphql\plugin), which causesrequire.resolveto fail when the NestJS CLI attempts to load GraphQL plugins fromnest-cli.json.Using a forward-slash path (
${item}/${PLUGIN_ENTRY_FILENAME}) resolves correctly on all platforms including Windows.Steps to reproduce
@nestjs/cliv12 alpha on Windows@nestjs/graphqltopluginsinnest-cli.jsonnest build— fails with plugin resolution errorRelated issue
Windows backslash in
path.joinbreaksrequire.resolvefor npm packages with scoped names (e.g.@nestjs/graphql).