fix(compiler): validate asset output paths#3457
Merged
Merged
Conversation
Member
|
lgtm |
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The assets pipeline computes copy and unlink destinations from
"compilerOptions.assets[].outDir" without checking whether the final resolved
path remains inside the project directory.
As a result, a project configuration can point asset output to a parent or
absolute external directory.
nest buildmay then copy files outside theworkspace, and watch mode may remove the corresponding external destination on
asset unlink.
Issue Number: #3456
What is the new behavior?
AssetsManager now resolves the final asset destination against the project
root before any filesystem write or unlink is performed.
The helper refuses to process asset destinations that are:
This validation is used for both asset copy operations and watch-mode unlink
operations.
Regression tests were added for valid internal destinations and rejected
external destinations.
Does this PR introduce a breaking change?