Skip to content

chore(deps): update fsevents to 1.2.13#2281

Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom
dotlambda:fsevents-1.2.13
Sep 21, 2023
Merged

chore(deps): update fsevents to 1.2.13#2281
kamilmysliwiec merged 1 commit intonestjs:masterfrom
dotlambda:fsevents-1.2.13

Conversation

@dotlambda
Copy link
Copy Markdown
Contributor

@dotlambda dotlambda commented Sep 10, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

nest-cli fails to build on macOS:

npm ERR! In file included from ../fsevents.cc:6:
npm ERR! In file included from ../../nan/nan.h:2818:
npm ERR! ../../nan/nan_typedarray_contents.h:34:43: error: no member named 'GetContents' in 'v8::ArrayBuffer'
npm ERR!       data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;
npm ERR!                                   ~~~~~~~~^
npm ERR! ../fsevents.cc:43:32: error: no template named 'Handle' in namespace 'v8'
npm ERR!     static void Initialize(v8::Handle<v8::Object> exports);
npm ERR!                            ~~~~^
npm ERR! In file included from ../fsevents.cc:73:
npm ERR! ../src/constants.cc:89:11: error: no matching member function for call to 'Set'
npm ERR!   object->Set(Nan::New<v8::String>("kFSEventStreamEventFlagNone").ToLocalChecked(), Nan::New<v8::Integer>(kFSEventStreamEventFlagNone));
npm ERR!   ~~~~~~~~^~~
npm ERR! /nix/store/7d3111c1rxa9nk80zhq00q6vgaj1f66z-nodejs-18.17.1-source/deps/v8/include/v8-object.h:244:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
npm ERR!   V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
npm ERR!                                     ^
npm ERR! /nix/store/7d3111c1rxa9nk80zhq00q6vgaj1f66z-nodejs-18.17.1-source/deps/v8/include/v8-object.h:247:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
npm ERR!   V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
npm ERR! make: *** [fse.target.mk:129: Release/obj.target/fse/fsevents.o] Error 1

What is the new behavior?

It builds on macOS.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 2e73b9d into nestjs:master Sep 21, 2023
@dotlambda dotlambda deleted the fsevents-1.2.13 branch September 21, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants