fix(core): prevent injector hang when design:paramtypes is missing#16683
Merged
kamilmysliwiec merged 1 commit intoApr 3, 2026
Merged
Conversation
When `emitDecoratorMetadata` is unavailable (e.g. esbuild), `@Inject()` decorators create a sparse array via `SELF_DECLARED_DEPS_METADATA`. `Array.prototype.map` skips sparse holes, so the `Barrier` in `resolveConstructorParams` never receives enough signals and hangs indefinitely. Use `Array.from()` in `reflectConstructorParams` to convert sparse arrays into dense arrays with explicit `undefined` values, ensuring `map` iterates every index and the Barrier resolves correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pull Request Test Coverage Report for Build 5b453f7a-8504-40fb-838b-26f8af740f6cDetails
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
emitDecoratorMetadatais unavailable (e.g. esbuild),@Inject()decorators create a sparse array viaSELF_DECLARED_DEPS_METADATA.Array.prototype.mapskips sparse holes, so theBarrierinresolveConstructorParamsnever receives enough signals and hangs indefinitely.Use
Array.from()inreflectConstructorParamsto convert sparse arrays into dense arrays with explicitundefinedvalues, ensuringmapiterates every index and the Barrier resolves correctly.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information