fix(core): dependency injection edge case with moduleref.create#16637
Merged
kamilmysliwiec merged 1 commit intoMar 30, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 418d0a06-962c-43dd-b62b-c99d2704a8b1Details
💛 - Coveralls |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Injecting a
Scope.TRANSIENTdependency into a regular@Injectablethat's instantiated withModuleRef.createresults in a "phantom" class, that's not correctly instantiated - the dependencies of the transient service that are not injected.What is the new behavior?
The dependencies of the transient service are injected correctly.
Does this PR introduce a breaking change?
Other information
Disclaimer: the fix was made by an LLM. I simply provided the
.spec.tsfile and asked it to fix it, I don't understand NestJS deeply enough to understand the fix fully.Besides that, I didn't know where I should place the test file, open to suggestions if the current place is unfitting 😄