fix(common): improve error handling in FileTypeValidator#16100
Merged
kamilmysliwiec merged 3 commits intoDec 21, 2025
Conversation
Add warning logs when file-type package fails to load due to ESM import issues. This helps users debug issues when running tests with Jest without --experimental-vm-modules flag. When loading fails and fallbackToMimetype is enabled, the validator now correctly falls back to mimetype comparison instead of silently returning false. Closes nestjs#15055
6 tasks
Pull Request Test Coverage Report for Build c7ef8c4e-aa6e-4c83-9dd5-2308d11676edDetails
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Issue Number: #15055
FileTypeValidatorsilently returnsfalsewhen ESM loading fails (e.g., in Jest without--experimental-vm-modules), making it difficult to diagnose why file validation is failing.What is the new behavior?
file-typepackage fails to load due to ESM issuesfallbackToMimetypeoption is enabled and loading failsDoes this PR introduce a breaking change?