fix(core): instantiate nested transient providers in static context#16098
Merged
kamilmysliwiec merged 3 commits intoDec 21, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build c3b1f3ec-bdab-4a0e-a61d-21b32d8dc74bDetails
💛 - Coveralls |
Member
|
We might want to add an integration test, just in case - to ensure this doesn't happen again in the future |
4 tasks
Comment on lines
+420
to
+424
| (isStaticTransient && !!rootInquirer && !rootInquirer.isTransient) || | ||
| (isStaticTransient && | ||
| !!inquirer && | ||
| inquirer.isTransient && | ||
| !rootInquirer)) |
Member
There was a problem hiding this comment.
nit: i wonder if - instead of just adding another newline - it would have been better to break this down into if-else clauses with corresponding comments
Contributor
Author
There was a problem hiding this comment.
I agree, refactored the method with if-else clauses and comments for better readability.
Member
|
LGTM |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a DEFAULT-scoped provider depends on a nested TRANSIENT chain (e.g.,
Controller → TransientA → TransientB), the nested TRANSIENT provider's constructor is not called. The instance exists as a prototype only, causing class fields to beundefined.Issue Number: #16097
What is the new behavior?
Nested TRANSIENT providers are now properly instantiated in STATIC_CONTEXT. The
isStatic()method now returnstruewhen the inquirer is TRANSIENT with a static dependency tree and norootInquirerset.Does this PR introduce a breaking change?
Other information
Related PRs: