Skip to content

fix(microservices): fix grpc stream method return type#16072

Merged
kamilmysliwiec merged 1 commit into
nestjs:masterfrom
shash-hq:fix/grpc-observable-return
Dec 15, 2025
Merged

fix(microservices): fix grpc stream method return type#16072
kamilmysliwiec merged 1 commit into
nestjs:masterfrom
shash-hq:fix/grpc-observable-return

Conversation

@shash-hq

@shash-hq shash-hq commented Dec 14, 2025

Copy link
Copy Markdown
Contributor

Ensure GrpcStreamMethod returns Observable directly instead of wrapping it in a Promise when called locally.

Closes #15953

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Ensure GrpcStreamMethod returns Observable directly instead of wrapping it in a Promise when called locally.

Closes nestjs#15953
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build e068ab87-f109-4eec-9ccb-80912c0cb985

Details

  • 4 of 8 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 89.661%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/decorators/message-pattern.decorator.ts 4 8 50.0%
Totals Coverage Status
Change from base Build eaf9b6b0-1f07-466d-8da5-2f41241edd3c: -0.005%
Covered Lines: 7406
Relevant Lines: 8260

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 4d57c21 into nestjs:master Dec 15, 2025
2 checks passed
@kamilmysliwiec

Copy link
Copy Markdown
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GrpcStreamMethod wraps Observable into a hidden Promise

4 participants