Switch Bolt protocol version to dedicated type#1321
Merged
Conversation
| if (!(version instanceof ProtocolVersion) || version === undefined || version === null) { | ||
| throw newError('Unknown Bolt protocol version: ' + version) | ||
| } | ||
| switch (version.toString()) { |
There was a problem hiding this comment.
I'm not hugely experienced in JS, and I know that you can't override the equality operator like you can in some other languages. But is there a way to do the switch without string comparison? Something like:
switch (true) {
case version.equals(BOLT_PROTOCOL_V1):
break;
case version.equals(BOLT_PROTOCOL_V5):
break;
default:
// default case
}
No idea if that would be preferable or idiomatic in JS, but to my C# brain it's preferable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selected bolt protocol version is represented as a floating point number in multiple places in the code. This is currently fine, but would cause the whole driver to explode if/when we introduce bolt 5.10 or 6.10.
This PR addresses this tech debt before it causes a larger issue