Reduce contention on ConsumerStore creation#7700
Merged
neilalexander merged 1 commit intomainfrom Jan 6, 2026
Merged
Conversation
Previously creating a `ConsumerStore` required taking the stream lock to determine whether the parent stream store was closed or not. Switch to an atomic so that this no longer requires the lock. This should speed up creating consumers in a system where the streams are heavily loaded or contended. Signed-off-by: Neil Twigg <neil@nats.io>
This was referenced Jan 6, 2026
neilalexander
added a commit
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously creating a
ConsumerStorerequired taking the stream lock to determine whether the parent stream store was closed or not. Switch to an atomic so that this no longer requires the lock.This should speed up creating consumers in a system where the streams are heavily loaded or contended.
Signed-off-by: Neil Twigg neil@nats.io