Implement Builder API for creating tar archives#90
Merged
Brooooooklyn merged 5 commits intomainfrom Aug 11, 2025
Merged
Conversation
Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement @napi-rs/tar/issues/3 add tests
Implement Builder API for creating tar archives
Aug 11, 2025
Member
|
@copilot run cargo fmt, and skip three failing tests on wasi: |
Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
Contributor
Author
Brooooooklyn
approved these changes
Aug 11, 2025
Sphinm
pushed a commit
to Sphinm/tar-cross-platform
that referenced
this pull request
Aug 31, 2025
* Initial plan * Initial analysis and plan for Builder API implementation Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com> * Implement Builder API with comprehensive tests Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com> * Clean up test artifacts and update gitignore Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com> * Run cargo fmt and skip three Builder tests on WASI Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Builder API for creating tar archives, addressing issue #3. The implementation provides a complete solution for programmatically creating tar archives from various sources.
New Builder Class
The Builder API mirrors the functionality of Rust's
tar::Builderand provides the following methods:Usage Examples
Creating archives in memory:
Creating archives to file:
Key Features
Implementation Details
The Rust implementation uses a
BuilderOutputenum to handle both file and memory-based outputs:This allows the same Builder interface to work seamlessly with both output modes while maintaining optimal performance.
Testing
Added comprehensive test coverage with 11 new tests covering:
All existing tests continue to pass, ensuring backward compatibility.
Documentation
Updated README with complete Builder API documentation and usage examples. TypeScript definitions are automatically generated from the Rust implementation.
Closes #3
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.