chore(napi): deprecate Env::create_reference#2347
Merged
Brooooooklyn merged 1 commit intomainfrom Nov 7, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 33164be | Previous: f2377e2 | Ratio |
|---|---|---|---|
noop#napi-rs |
86454072 ops/sec (±0.15%) |
86502656 ops/sec (±0.15%) |
1.00 |
noop#JavaScript |
819929189 ops/sec (±0.11%) |
818277384 ops/sec (±0.1%) |
1.00 |
Plus number#napi-rs |
18553882 ops/sec (±0.82%) |
22921082 ops/sec (±0.5%) |
1.24 |
Plus number#JavaScript |
817902544 ops/sec (±0.1%) |
815170832 ops/sec (±0.24%) |
1.00 |
Create buffer#napi-rs |
649297 ops/sec (±12.02%) |
617986 ops/sec (±13.66%) |
0.95 |
Create buffer#JavaScript |
3267863 ops/sec (±2.05%) |
3195858 ops/sec (±2.46%) |
0.98 |
createArray#createArrayJson |
53429 ops/sec (±1.09%) |
53212 ops/sec (±0.46%) |
1.00 |
createArray#create array for loop |
9849 ops/sec (±0.36%) |
9895 ops/sec (±0.59%) |
1.00 |
createArray#create array with serde trait |
9890 ops/sec (±1.41%) |
9931 ops/sec (±0.58%) |
1.00 |
getArrayFromJs#get array from json string |
23244 ops/sec (±0.98%) |
23467 ops/sec (±0.55%) |
1.01 |
getArrayFromJs#get array from serde |
13030 ops/sec (±0.22%) |
13617 ops/sec (±0.35%) |
1.05 |
getArrayFromJs#get array with for loop |
15949 ops/sec (±0.39%) |
15974 ops/sec (±0.46%) |
1.00 |
Get Set property#Get Set from native#u32 |
580750 ops/sec (±12.33%) |
543258 ops/sec (±13.02%) |
0.94 |
Get Set property#Get Set from JavaScript#u32 |
555847 ops/sec (±2.39%) |
538847 ops/sec (±2.45%) |
0.97 |
Get Set property#Get Set from native#string |
571149 ops/sec (±11.45%) |
564204 ops/sec (±12.3%) |
0.99 |
Get Set property#Get Set from JavaScript#string |
524998 ops/sec (±1.85%) |
521239 ops/sec (±1.86%) |
0.99 |
Async task#spawn task |
26864 ops/sec (±0.8%) |
26577 ops/sec (±0.66%) |
0.99 |
Async task#ThreadSafeFunction |
9548 ops/sec (±0.92%) |
9339 ops/sec (±0.83%) |
0.98 |
Async task#Tokio future to Promise |
32225 ops/sec (±0.71%) |
32056 ops/sec (±0.82%) |
0.99 |
Query#query * 100 |
3582 ops/sec (±0.85%) |
3554 ops/sec (±0.43%) |
0.99 |
Query#query * 1 |
26872 ops/sec (±0.77%) |
26009 ops/sec (±0.87%) |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
added a commit
to Brooooooklyn/canvas
that referenced
this pull request
Nov 7, 2024
There 2 leak points in the `Image` class. 1. The `Env::create_reference` was wrong in NAPI-RS, related pr: napi-rs/napi-rs#2347, change to the `Ref::new` can resolve it. 2. The `PromiseRaw::catch` callback was leaked, it cause the whole `Image` objects not be GCed, it was fixed in napi-rs/napi-rs#2348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.