Skip to content

chore(napi): remove Read from Uint8Array#2346

Merged
Brooooooklyn merged 1 commit intomainfrom
11-07-chore_napi_remove_read_from_uint8array
Nov 7, 2024
Merged

chore(napi): remove Read from Uint8Array#2346
Brooooooklyn merged 1 commit intomainfrom
11-07-chore_napi_remove_read_from_uint8array

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

@Brooooooklyn Brooooooklyn force-pushed the 11-07-chore_napi_remove_read_from_uint8array branch from 3531333 to 7662b48 Compare November 7, 2024 03:33
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 7662b48 Previous: f2377e2 Ratio
noop#napi-rs 86922708 ops/sec (±0.36%) 86502656 ops/sec (±0.15%) 1.00
noop#JavaScript 822837870 ops/sec (±0.1%) 818277384 ops/sec (±0.1%) 0.99
Plus number#napi-rs 23606430 ops/sec (±0.09%) 22921082 ops/sec (±0.5%) 0.97
Plus number#JavaScript 821236867 ops/sec (±0.12%) 815170832 ops/sec (±0.24%) 0.99
Create buffer#napi-rs 686065 ops/sec (±11.92%) 617986 ops/sec (±13.66%) 0.90
Create buffer#JavaScript 3383634 ops/sec (±1.92%) 3195858 ops/sec (±2.46%) 0.94
createArray#createArrayJson 54184 ops/sec (±0.5%) 53212 ops/sec (±0.46%) 0.98
createArray#create array for loop 9689 ops/sec (±1.05%) 9895 ops/sec (±0.59%) 1.02
createArray#create array with serde trait 9891 ops/sec (±0.49%) 9931 ops/sec (±0.58%) 1.00
getArrayFromJs#get array from json string 23748 ops/sec (±0.5%) 23467 ops/sec (±0.55%) 0.99
getArrayFromJs#get array from serde 13626 ops/sec (±0.47%) 13617 ops/sec (±0.35%) 1.00
getArrayFromJs#get array with for loop 16188 ops/sec (±0.19%) 15974 ops/sec (±0.46%) 0.99
Get Set property#Get Set from native#u32 564801 ops/sec (±12.71%) 543258 ops/sec (±13.02%) 0.96
Get Set property#Get Set from JavaScript#u32 552024 ops/sec (±2.55%) 538847 ops/sec (±2.45%) 0.98
Get Set property#Get Set from native#string 561339 ops/sec (±12.47%) 564204 ops/sec (±12.3%) 1.01
Get Set property#Get Set from JavaScript#string 524790 ops/sec (±1.83%) 521239 ops/sec (±1.86%) 0.99
Async task#spawn task 26956 ops/sec (±0.49%) 26577 ops/sec (±0.66%) 0.99
Async task#ThreadSafeFunction 9695 ops/sec (±0.74%) 9339 ops/sec (±0.83%) 0.96
Async task#Tokio future to Promise 32674 ops/sec (±0.81%) 32056 ops/sec (±0.82%) 0.98
Query#query * 100 3546 ops/sec (±0.53%) 3554 ops/sec (±0.43%) 1.00
Query#query * 1 26636 ops/sec (±0.83%) 26009 ops/sec (±0.87%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@Brooooooklyn Brooooooklyn merged commit ae8eab3 into main Nov 7, 2024
@Brooooooklyn Brooooooklyn deleted the 11-07-chore_napi_remove_read_from_uint8array branch November 7, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant