feat(cli): support ESM binding#2284
Merged
Brooooooklyn merged 4 commits intonapi-rs:mainfrom Oct 15, 2024
Merged
Conversation
Member
Brooooooklyn
left a comment
There was a problem hiding this comment.
How about keep the cjs format (for cjs projects), and create the esm binding from cjs file:
import { createRequire } from 'node:module';
const require = createRequire(import.meta.url);
const __dirname = new URL('.', import.meta.url).pathname;
export const { Foo, Bar, Baz } = require('./index.js')
Contributor
Author
That could work. Although, the DX is annoying in that it would be another file to configure. Eg: |
richerfu
pushed a commit
to richerfu/napi-rs
that referenced
this pull request
Oct 23, 2024
* feat: support ESM binding * chore: consistent use of semicolons * chore: apply suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createCjsBindinginto reusable code chunkscreateCommonBindingandbindingHeadercreateEsmBinding--esmoption to build command to select esm vs cjs binding