Skip to content

switch to current branch or stay detach (except code sync)#7

Merged
mmathieum merged 2 commits into
masterfrom
mm/new_change
Apr 17, 2026
Merged

switch to current branch or stay detach (except code sync)#7
mmathieum merged 2 commits into
masterfrom
mm/new_change

Conversation

@mmathieum

Copy link
Copy Markdown
Member

No description provided.

@mmathieum mmathieum self-assigned this Apr 17, 2026
@mmathieum

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refines the branch switching logic in the GitHub Action setup by focusing on the $MT_BRANCH_NAME variable and providing a fallback message for detached states. The review feedback recommends removing the commented-out code blocks to maintain cleanliness and double-quoting the branch name variable to prevent potential shell expansion issues.

Comment thread .github/actions/setup/action.yml
Comment thread .github/actions/setup/action.yml

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the branch switching logic for submodules and the repository by targeting a specific branch or remaining detached, rather than using multiple fallbacks. Feedback suggests updating step names for accuracy, removing dead code, and quoting shell variables to ensure robustness against special characters.

Comment thread .github/actions/setup/action.yml Outdated
Comment thread .github/actions/setup/action.yml
Comment thread .github/actions/setup/action.yml
@mmathieum mmathieum marked this pull request as ready for review April 17, 2026 19:01
@mmathieum mmathieum changed the title On switch to current branch or stay detach (except code sync) switch to current branch or stay detach (except code sync) Apr 17, 2026
@mmathieum mmathieum merged commit 8f2479c into master Apr 17, 2026
@mmathieum mmathieum deleted the mm/new_change branch April 17, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant