Correct formatting for round_up rounding mode#834
Merged
skirpichev merged 4 commits intompmath:masterfrom Aug 10, 2024
Merged
Conversation
skirpichev
requested changes
Aug 4, 2024
Collaborator
skirpichev
left a comment
There was a problem hiding this comment.
You should include tests.
skirpichev
reviewed
Aug 4, 2024
* Made it so that when rounding up, and the digit rounded to is a 0, all of the following digits are checked.
skirpichev
requested changes
Aug 6, 2024
Collaborator
skirpichev
left a comment
There was a problem hiding this comment.
Could you, please, adjust PR title and description?
round_up rounding mode
skirpichev
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the code in
round_digits: now the first digit in thestddigitslist is excluded from the list of digits that must be rounded up when theround_uprounding mode is used. When rounding to a 0 digit, all the digits following it are looked up, and if one of them is different from 0, the 0 is rounded up.This fixes some wrongfully formatted floats as, for example, when running the following code in the master branch