Skip to content

Support randmatrix() for mp.iv and mp contexts#527

Merged
skirpichev merged 1 commit intompmath:masterfrom
MaxGaukler:randmatrix
Jun 26, 2023
Merged

Support randmatrix() for mp.iv and mp contexts#527
skirpichev merged 1 commit intompmath:masterfrom
MaxGaukler:randmatrix

Conversation

@MaxGaukler
Copy link
Copy Markdown
Contributor

@MaxGaukler MaxGaukler commented Mar 20, 2020

Before, mpmath.iv.randmatrix() caused an error. Now it works correctly:

>>> import mpmath
>>> mpmath.iv.randmatrix(3)
matrix(
[['[0.66382280562735496154, 0.66382280562735496154]', '[0.016861908353603016764, 0.016861908353603016764]', '[0.73734056129022396142, 0.73734056129022396142]'],
 ['[0.36647301100616180847, 0.36647301100616180847]', '[0.62220372249504873885, 0.62220372249504873885]', '[0.48761902415903068952, 0.48761902415903068952]'],
 ['[0.81322606973113087392, 0.81322606973113087392]', '[0.15903271707414323721, 0.15903271707414323721]', '[0.090983058161586249923, 0.090983058161586249923]']])
>>> type(mpmath.fp.randmatrix(3)[0,0])
<type 'float'>
>>> type(mpmath.mp.randmatrix(3)[0,0])
<class 'mpmath.ctx_mp_python.mpf'>
>>> type(mpmath.iv.randmatrix(3)[0,0])
<class 'mpmath.ctx_iv.ivmpf'>
  • Is it okay that I moved import random to the top level? AFAIK it should even be faster this way.

@fredrik-johansson
Copy link
Copy Markdown
Collaborator

fredrik-johansson commented Mar 22, 2020

There is a small problem: random.random() returns a random double, so this will not give full precision random numbers.

@mgmax
Copy link
Copy Markdown

mgmax commented Mar 23, 2020

Should be better now. I added tests, but am not sure how workprec() is supposed to work for iv. Is that a bug or by design?

@MaxGaukler
Copy link
Copy Markdown
Contributor Author

MaxGaukler commented Mar 23, 2020

By the way, please let me know as soon as you consider it ready for merging so that I can provide a rebased version of this pull request as a single commit.

@skirpichev
Copy link
Copy Markdown
Collaborator

skirpichev commented May 11, 2023

@MaxGaukler could you please fix merge conflicts?

@MaxGaukler MaxGaukler force-pushed the randmatrix branch 2 times, most recently from d92aa5e to 7f5cf5e Compare May 11, 2023 17:57
@MaxGaukler
Copy link
Copy Markdown
Contributor Author

MaxGaukler commented May 11, 2023

Now squashed and rebased. Happy to see that there is interest in my suggestion :-)

skirpichev
skirpichev reviewed Jun 3, 2023
View reviewed changes
skirpichev
skirpichev requested changes Jun 3, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also merge conflicts. Please fix them.

Except for comment in the ctx_fp.py and above remark - seems ok for me.

@MaxGaukler
Support randmatrix() for mp.iv and mp contexts
4bad21d 
To make this work correctly, rand() now supports arbitrary precision:

>>> x = mpmath.iv.rand() * mpmath.iv.convert(2**53)
>>> x - int(x)
mpi('0.0', '0.0')
>>> mpmath.iv.prec=1234
>>> x = mpmath.iv.rand() * mpmath.iv.convert(2**53)
>>> x - int(x)
mpi('0.05786680052076454587 ...
@MaxGaukler MaxGaukler requested a review from skirpichev June 10, 2023 20:14
@skirpichev skirpichev merged commit 42a77be into mpmath:master Jun 26, 2023
@skirpichev skirpichev added this to the 1.4 milestone May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4

Development

Successfully merging this pull request may close these issues.

4 participants

@MaxGaukler @fredrik-johansson @mgmax @skirpichev