Test/frozen package version#1055
Merged
skirpichev merged 12 commits intompmath:masterfrom Mar 7, 2026
Merged
Conversation
skirpichev
requested changes
Mar 3, 2026
Collaborator
skirpichev
left a comment
There was a problem hiding this comment.
Please see some comments.
Test is quick enough, so please also add it to the "needs" list of the tests job.
added 3 commits
March 5, 2026 09:44
- Remove job name
- Add comment referencing issue - Use 'mktemp' for the temporary directory - Remove '--quiet' and install all dependencies in one step - Remove redundant comments
FlurinArner
commented
Mar 5, 2026
skirpichev
reviewed
Mar 5, 2026
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
- Working directory independent root directory for mpmath - Remove *.spec from initial clean up (legacy from pyinstaller before mktemp usage) - Update echo and remove redundant comments
skirpichev
approved these changes
Mar 7, 2026
Collaborator
skirpichev
left a comment
There was a problem hiding this comment.
I did some final edits, instead of trying to do yet another review turn, sorry.
Now looks good for me.
Contributor
Author
That's good for me! Thanks for the positive feedback and quick resolution. Just to be sure (since you moved the |
Merged
skirpichev
added a commit
to skirpichev/mpmath
that referenced
this pull request
Mar 10, 2026
Add bash script to test package version in a frozen application version and a separate CI job to run it. Closes mpmath#1044. Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> (cherry picked from commit 45f5adb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyinstallerfrozen application generation andmpmath.__version__availablity.mpmath/tests/test_version_frozen.shtest_local/folder generated in thetest_version_frozen.shbash script.closes #1044