Skip to content

chore(deps): Upgrade chrome-launcher from 0.15.1 to 1.1.2#3200

Merged
Rob--W merged 1 commit intomozilla:masterfrom
aklinker1:chrome-launcher-1.1
Jul 16, 2024
Merged

chore(deps): Upgrade chrome-launcher from 0.15.1 to 1.1.2#3200
Rob--W merged 1 commit intomozilla:masterfrom
aklinker1:chrome-launcher-1.1

Conversation

@aklinker1
Copy link
Contributor

@aklinker1 aklinker1 commented Jul 16, 2024

Extracted from #2912, and replaces #3170.

@aklinker1 aklinker1 changed the title chore(deps): Upgrade chrome-launcher to 1.1.2 chore(deps): Upgrade chrome-launcher from 0.15.1 to 1.1.2 Jul 16, 2024
Copy link
Contributor Author

@aklinker1 aklinker1 Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the changes to the default flags seem relevant to extensions so I didn't adjust the filtering, but someone more familiar with browsers might want to double check.

@aklinker1 aklinker1 marked this pull request as ready for review July 16, 2024 16:29
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

// Flags from chrome-launcher v0.14.0
const expectedFlags = [
'--disable-features=Translate',
'--disable-features=Translate,OptimizationHints,MediaRouter,DialMediaRouteProvider,CalculateNativeWinOcclusion,InterestFeedContentSuggestions,CertificateTransparencyComponentUpdater,AutofillServerCommunication,PrivacySandboxSettings4',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of these cover the new search engines picker? It's quite annoying.

Starting a new profile (web-ext run --target chromium) is basically a whack-a-mole.

@aklinker1 aklinker1 deleted the chrome-launcher-1.1 branch August 4, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants