Skip to content

fix: typo and missed async keyword#3177

Merged
Rob--W merged 1 commit intomozilla:masterfrom
Decodetalkers:typo
Jun 21, 2024
Merged

fix: typo and missed async keyword#3177
Rob--W merged 1 commit intomozilla:masterfrom
Decodetalkers:typo

Conversation

@Decodetalkers
Copy link
Contributor

I am reading the repo to learn something, but typos-lsp told me that there are some typos. So I think maybe I can make a pr.. and lsp said that there are some async keywords are missing.

@Rob--W
Copy link
Member

Rob--W commented Jun 21, 2024

async is not strictly necessary if a Promise is already returned, but adding it does not hurt either.

@Rob--W Rob--W merged commit b50b2f4 into mozilla:master Jun 21, 2024
@Decodetalkers Decodetalkers deleted the typo branch June 21, 2024 14:51
aklinker1 pushed a commit to aklinker1/web-ext that referenced this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants