Skip to content

fix the case when aws session token is from env#729

Merged
blink1073 merged 3 commits intomongodb-labs:masterfrom
strogiyotec:assume_role_fix
Jan 21, 2026
Merged

fix the case when aws session token is from env#729
blink1073 merged 3 commits intomongodb-labs:masterfrom
strogiyotec:assume_role_fix

Conversation

@strogiyotec
Copy link
Copy Markdown
Contributor

JAVA-6064 : Failing AWS auth functional test

Summary

The java driver has the following functional test
It's annotated as ignored if session token is not present in env variables
The test is checking that mongo connection will fail when fake aws session is given
But because of this commit the session token is now exposed in env variables which makes this test run and fail because the fake token is ignored and connection is not failing

Changes in this PR

This PR skips saving aws session in env variables when no uri is present

Test Plan

For now it was only testes against java build
Here is the patch

Checklist

Checklist for Author

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@durran
Copy link
Copy Markdown
Contributor

durran commented Jan 21, 2026

@blink1073
Copy link
Copy Markdown
Member

@blink1073 blink1073 merged commit 8ad8660 into mongodb-labs:master Jan 21, 2026
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants