Skip to content

test(NODE-7394): add test suite that runs with TLS enabled#4845

Merged
tadjik1 merged 10 commits intomainfrom
NODE-7359
Jan 28, 2026
Merged

test(NODE-7394): add test suite that runs with TLS enabled#4845
tadjik1 merged 10 commits intomainfrom
NODE-7359

Conversation

@baileympearson
Copy link
Copy Markdown
Contributor

@baileympearson baileympearson commented Jan 21, 2026

Description

Summary of Changes

This PR does two things:

  • Adds a testing variant that runs with TLS enabled in CI
  • Addresses the concerns with the backpressure test fromNODE-7394 (you can confirm that this test is running and passing in 8.0+ CI variants in the TLS tests task)

Along the way, I encountered a few issues:

So, some test suites are skipped for now. Other suites have explicit calls to MongoClient.connect() to avoid NODE-7398.

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review January 22, 2026 23:22
@baileympearson baileympearson requested a review from a team as a code owner January 22, 2026 23:22
@baileympearson baileympearson changed the title WIP test(NODE-7359): add test suite that runs with TLS enabled test(NODE-7394): add test suite that runs with TLS enabled Jan 22, 2026
@tadjik1 tadjik1 self-assigned this Jan 23, 2026
@tadjik1 tadjik1 added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 23, 2026
Copy link
Copy Markdown
Member

@tadjik1 tadjik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @baileympearson! Thank you 👍

@tadjik1 tadjik1 added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 28, 2026
@tadjik1 tadjik1 requested a review from a team January 28, 2026 11:29
Copy link
Copy Markdown
Contributor

@PavelSafronov PavelSafronov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, thanks for this.

@tadjik1 tadjik1 merged commit 0358360 into main Jan 28, 2026
30 checks passed
@tadjik1 tadjik1 deleted the NODE-7359 branch January 28, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants