Skip to content

Update DatabaseTestCase to Junit 5#1238

Merged
rozza merged 3 commits into
mongodb:masterfrom
rozza:JAVA-5220
Oct 31, 2023
Merged

Update DatabaseTestCase to Junit 5#1238
rozza merged 3 commits into
mongodb:masterfrom
rozza:JAVA-5220

Conversation

@rozza

@rozza rozza commented Oct 31, 2023

Copy link
Copy Markdown
Member

@rozza rozza requested a review from stIncMale October 31, 2023 12:45
@rozza

rozza commented Oct 31, 2023

Copy link
Copy Markdown
Member Author

I opted to leave driver-legacy code as that has more substantive changes - lots of use of assumeThat with hamcrest matchers, which don't directly port to Junit5

@jyemin jyemin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional change request, but LGTM.

@jyemin jyemin removed the request for review from stIncMale October 31, 2023 13:07
@rozza rozza merged commit 8043b35 into mongodb:master Oct 31, 2023
@rozza rozza deleted the JAVA-5220 branch October 31, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants