Skip to content

Enable container and Kubernetes awareness for improved telemetry.#1235

Merged
vbabanin merged 6 commits into
mongodb:masterfrom
vbabanin:JAVA-5072
Oct 30, 2023
Merged

Enable container and Kubernetes awareness for improved telemetry.#1235
vbabanin merged 6 commits into
mongodb:masterfrom
vbabanin:JAVA-5072

Conversation

@vbabanin

@vbabanin vbabanin commented Oct 27, 2023

Copy link
Copy Markdown
Member

Include container and Kubernetes awareness, as specified in the MongoDB Handshake Specification

JAVA-5072

Comment thread build.gradle
testImplementation 'org.spockframework:spock-core'
testImplementation 'org.spockframework:spock-junit4'
testImplementation("org.mockito:mockito-core:3.8.0")
testImplementation("org.mockito:mockito-inline:3.8.0")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This useful addon to Mockito allows for the mocking of static methods.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vbabanin vbabanin marked this pull request as ready for review October 27, 2023 23:33
@vbabanin vbabanin requested a review from rozza October 27, 2023 23:35
}

private enum Environment {
private enum FaasEnvironment {

@vbabanin vbabanin Oct 27, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the introduction of new parameters in the env section related to containers/orchestration, I've renamed this enum in accordance with the specification, as it contains metadata of FaaS environment.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@rozza rozza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

private enum Environment {
private enum FaasEnvironment {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Comment thread build.gradle
testImplementation 'org.spockframework:spock-core'
testImplementation 'org.spockframework:spock-junit4'
testImplementation("org.mockito:mockito-core:3.8.0")
testImplementation("org.mockito:mockito-inline:3.8.0")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vbabanin vbabanin merged commit fd8352f into mongodb:master Oct 30, 2023
@vbabanin vbabanin deleted the JAVA-5072 branch October 30, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants