Skip to content

Exclude :graalvm-native-image-app from being published#1362

Merged
stIncMale merged 2 commits into
mongodb:masterfrom
stIncMale:JAVA-5414
Apr 11, 2024
Merged

Exclude :graalvm-native-image-app from being published#1362
stIncMale merged 2 commits into
mongodb:masterfrom
stIncMale:JAVA-5414

Conversation

@stIncMale

@stIncMale stIncMale commented Apr 10, 2024

Copy link
Copy Markdown
Member

Tested by manually doing the following:

  • rm -r ~/.m2/repository/org/mongodb
  • rm -r ./build/docs
  • ./gradlew clean docs publishToMavenLocal -x signMavenJavaPublication
    • check that ./build/docs/bson exists and ./build/docs/graalvm-native-image-app does not.
  • check that ~/.m2/repository/org/mongodb/bson exists and ~/.m2/repository/org/mongodb/graalvm-native-image-app does not.

JAVA-5414

@stIncMale stIncMale self-assigned this Apr 10, 2024
@stIncMale stIncMale requested a review from jyemin April 10, 2024 21:59

@jyemin jyemin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also this line in build.gradle:

def javaCodeCheckedProjects = javaMainProjects.findAll { !['driver-benchmarks', 'driver-workload-executor', 'driver-lambda'].contains(it.name) }

and this in gradle/javadoc.gradle:

def projectsThatDoNotPublishJavaDocs = project(":util").allprojects + project(":driver-benchmarks") + project("driver-workload-executor") + project("driver-lambda")

I think graalvm-native-image-app should be added in those places too.

@stIncMale

stIncMale commented Apr 10, 2024

Copy link
Copy Markdown
Member Author

Thanks! I agree about projectsThatDoNotPublishJavaDocs, as all the javadocs get generated in the same place, not in build subdirectories of each project. However, I don't think javaCodeCheckedProjects needs to be updated - there is nothing wrong with :graalvm-native-image-app being statically checked. The checks still seem valuable, despite the code not being intended for production.

@stIncMale stIncMale requested a review from jyemin April 10, 2024 22:34
@stIncMale stIncMale merged commit 7bf5ec2 into mongodb:master Apr 11, 2024
@stIncMale stIncMale deleted the JAVA-5414 branch April 11, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants