Follow unacknowledged write with a find in spec tests#1355
Merged
Conversation
stIncMale
approved these changes
Apr 3, 2024
Member
|
Why is the PR named "WIP", is there something that it is currently missing? |
Collaborator
Author
|
Sorry, it was WIP while the test changes were going through code review in the specifications repo. I updated the title and description, and will edit the commit message during the merge process. |
Member
It's still "WIP" |
jyemin
commented
Apr 3, 2024
| { | ||
| "description": "command-logging", | ||
| "schemaVersion": "1.13", | ||
| "description": "unacknowledged-write", |
Collaborator
Author
There was a problem hiding this comment.
This line was from a previous change to the file
| { | ||
| "description": "unacknowledgedBulkWrite", | ||
| "schemaVersion": "1.0", | ||
| "schemaVersion": "1.7", |
Collaborator
Author
There was a problem hiding this comment.
Required for ignoreExtraEvents
| "description": "command-logging", | ||
| "schemaVersion": "1.13", | ||
| "description": "unacknowledged-write", | ||
| "schemaVersion": "1.16", |
Collaborator
Author
There was a problem hiding this comment.
Required for ignoreExtraMessages
stIncMale
approved these changes
Apr 3, 2024
jyemin
added a commit
that referenced
this pull request
Apr 3, 2024
This will force completion of the unacknowledged write, which addresses a TCP-based race condition in the tests JAVA-5398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will force completion of the w: 0 write, which addresses a TCP-based race condition in the tests
JAVA-5398