Skip to content

Add HTML support for relative URL rewrites#252

Merged
mondeja merged 7 commits intomondeja:masterfrom
maekawataiki:feat/html-image
Feb 5, 2025
Merged

Add HTML support for relative URL rewrites#252
mondeja merged 7 commits intomondeja:masterfrom
maekawataiki:feat/html-image

Conversation

@maekawataiki
Copy link
Contributor

@maekawataiki maekawataiki commented Jan 19, 2025 •
edited
Loading

Description of Change

  • New Feature:
    • Add raw html (image, source, a) support for rewrite_relative_url.
  • Fix:
    • Support external top level domain

Checklist

  • Feature working
  • Updated unit test

Related Issue

#251

@maekawataiki maekawataiki changed the title feat: add html image support for relative url rewrite feat: add html image and anchor support for relative url rewrite Jan 19, 2025
mondeja
mondeja requested changes Jan 20, 2025
View reviewed changes
mondeja
mondeja reviewed Jan 20, 2025
View reviewed changes
Copy link
Owner

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, it would be great to reuse the same approach for <source> HTML tags.

@mondeja mondeja linked an issue Jan 20, 2025 that may be closed by this pull request
Rewrite relative URLs for raw HTML in Markdown #251
Closed
@mondeja mondeja changed the title feat: add html image and anchor support for relative url rewrite Add HTML img support for relative url rewrites Jan 20, 2025
@maekawataiki maekawataiki changed the title Add HTML img support for relative url rewrites Add HTML support for relative url rewrites Jan 26, 2025
@maekawataiki
Copy link
Contributor Author

maekawataiki commented Jan 26, 2025

@mondeja Thank you for the review. I've added support for a and source tags.

mondeja
mondeja reviewed Jan 26, 2025
View reviewed changes
@maekawataiki
Copy link
Contributor Author

maekawataiki commented Jan 27, 2025

I've noticed currently this library doesn't support external top level domain (i.e. https://example.com) and throws error, so also adding fix and test for it.

@mondeja mondeja added the enhancement New feature or request label Jan 28, 2025
@maekawataiki maekawataiki requested a review from mondeja January 29, 2025 02:22
@maekawataiki
Copy link
Contributor Author

maekawataiki commented Jan 29, 2025 •
edited
Loading

Sorry, I haven't pushed the change. Just pushed the change.

mondeja
mondeja requested changes Jan 29, 2025
View reviewed changes
@mondeja mondeja self-requested a review February 1, 2025 10:54
@maekawataiki
Copy link
Contributor Author

maekawataiki commented Feb 5, 2025

@mondeja Thank you for the reviews. Do you have any other concern?

mondeja
mondeja approved these changes Feb 5, 2025
View reviewed changes
Copy link
Owner

@mondeja mondeja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Thanks for your work on this 🙏🏼

@mondeja mondeja changed the title Add HTML support for relative url rewrites Add HTML support for relative URL rewrites Feb 5, 2025
@mondeja mondeja merged commit c3bfd0a into mondeja:master Feb 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mondeja mondeja mondeja approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rewrite relative URLs for raw HTML in Markdown

2 participants

@maekawataiki @mondeja