Fix issue #560: fail to download license file because license name contains invalid characters#561
Merged
slawekjaranowski merged 1 commit intomojohaus:masterfrom Sep 14, 2024
Merged
Conversation
Member
|
@nhuongmh thanks for fixing .... method My proposition for refactor. Create class like 'LicenseFileNameBuilder' or similar name with body like: public class LicenseFileNameBuilder {
public LicenseFileNameBuilder withDepProject(...) {
return this;
}
public LicenseFileNameBuilder withUrl(...) {
return this;
}
// methods for ... rest of params
public String build() {
// body of current implementation
return null;
}
}Next we can simply create a Unit test for it. |
slawekjaranowski
approved these changes
Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As I have mentioned in the issue #560, currently some license file name contains illegal character in name which leads to fail to download license file from remote URL. I check the code and see there's already a regex to remove back slashes, but we need more than that. So I just added couple more illegal characters known as illegal.
I was built and tested on my project and the maven goal worked as expected.
Before:
After: