Skip to content

feat(vue3-bridge): add support for passing parameters to defineAsyncComponent#3268

Merged
danpeen merged 4 commits intomodule-federation:mainfrom
Dell-it:main
Nov 27, 2024
Merged

feat(vue3-bridge): add support for passing parameters to defineAsyncComponent#3268
danpeen merged 4 commits intomodule-federation:mainfrom
Dell-it:main

Conversation

@Dell-it
Copy link
Copy Markdown
Contributor

@Dell-it Dell-it commented Nov 24, 2024 •
edited
Loading

Description

Added the ability to pass parameters to defineAsyncComponent, which solves the following issues:

  • Enables control over fallback components and their display parameters;
  • Improves compatibility with Nuxt by allowing configuration of the suspensible parameter;
  • Eliminates the package requirement to Configure your bundler to alias "vue" to "vue/dist/vue.esm-bundler.js".

Also updated the documentation, which was outdated even before my changes.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b0030e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@module-federation/bridge-vue3 Major
@module-federation/runtime Major
@module-federation/enhanced Major
@module-federation/rspack Major
@module-federation/webpack-bundler-runtime Major
@module-federation/sdk Major
@module-federation/runtime-tools Major
@module-federation/managers Major
@module-federation/manifest Major
@module-federation/dts-plugin Major
@module-federation/third-party-dts-extractor Major
@module-federation/devtools Major
@module-federation/bridge-react Major
@module-federation/bridge-shared Major
@module-federation/bridge-react-webpack-plugin Major
@module-federation/modern-js Major
@module-federation/retry-plugin Major
@module-federation/data-prefetch Major
@module-federation/rsbuild-plugin Major
@module-federation/error-codes Major
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 24, 2024 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit b0030e0
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6743244601bad7000806cac4
😎 Deploy Preview https://deploy-preview-3268--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danpeen
Copy link
Copy Markdown
Contributor

danpeen commented Nov 27, 2024

thank you very much, i will take a look tomorrow

@danpeen danpeen merged commit 734df18 into module-federation:main Nov 27, 2024
@KyrieLii KyrieLii mentioned this pull request Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danpeen danpeen danpeen approved these changes

Assignees

No one assigned

Labels

change: feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dell-it @danpeen