Skip to content

Rename createScript to loadEntry#3257

Merged
ScriptedAlchemy merged 2 commits intomodule-federation:mainfrom
loveholly:docs/plugin-loadEntry
Nov 21, 2024
Merged

Rename createScript to loadEntry#3257
ScriptedAlchemy merged 2 commits intomodule-federation:mainfrom
loveholly:docs/plugin-loadEntry

Conversation

@loveholly
Copy link
Copy Markdown
Contributor

@loveholly loveholly commented Nov 19, 2024

Description

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c24eedf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit c24eedf
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/673ea1c6622083000861ce3a
😎 Deploy Preview https://deploy-preview-3257--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy
Copy link
Copy Markdown
Member

ScriptedAlchemy commented Nov 20, 2024

Create script is a hook that still exists.

@loveholly
Copy link
Copy Markdown
Contributor Author

loveholly commented Nov 21, 2024

Create script is a hook that still exists.

@ScriptedAlchemy Yes, I didn't change the createScript hooks, just correct the typo issue of loadEntry hooks

@loveholly
Copy link
Copy Markdown
Contributor Author

loveholly commented Nov 21, 2024

This is what it looks now, I think it was mis-spelled.
image

@ScriptedAlchemy
Copy link
Copy Markdown
Member

ScriptedAlchemy commented Nov 21, 2024

Ahhhhhh the diff didn't show enough context. Thank you

@ScriptedAlchemy ScriptedAlchemy merged commit a49bd33 into module-federation:main Nov 21, 2024
@loveholly loveholly deleted the docs/plugin-loadEntry branch November 22, 2024 01:48
@2heal1 2heal1 mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loveholly @ScriptedAlchemy