Skip to content

fix(enhanced): remove resolve replacements#3236

Merged
ScriptedAlchemy merged 1 commit intomainfrom
remove-resolve-replacements
Nov 17, 2024
Merged

fix(enhanced): remove resolve replacements#3236
ScriptedAlchemy merged 1 commit intomainfrom
remove-resolve-replacements

Conversation

@ScriptedAlchemy
Copy link
Copy Markdown
Member

@ScriptedAlchemy ScriptedAlchemy commented Nov 17, 2024 •
edited
Loading

Description

This pull request removes the resolution of the runtime path with the .esm.mjs extension when the federation runtime is set to "hoisted" mode. This simplifies the runtime path handling and ensures that the correct runtime path is used in the application, improving the overall reliability and maintainability of the codebase.

Related Issue

#3210

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: f21aca1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@module-federation/enhanced Patch
@module-federation/modern-js Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/rsbuild-plugin Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/runtime Patch
@module-federation/rspack Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/error-codes Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 17, 2024 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit f21aca1
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/673a3a375bf1c10008cabc9f
😎 Deploy Preview https://deploy-preview-3236--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

squadronai[bot]
squadronai bot reviewed Nov 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@squadronai squadronai bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Here is a concise summary of the pull request:

This pull request removes the resolution of the runtime path with the .esm.mjs extension when the federation runtime is set to "hoisted" mode. This simplifies the runtime path handling and ensures that the correct runtime path is used in the application, improving the overall reliability and maintainability of the codebase.

File Summaries
File Summary
packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts The code changes remove the replacement of the runtime path with the .esm.mjs extension when the federation runtime is set to "hoisted" mode. This simplifies the runtime path handling and ensures that the correct runtime path is used in the application.

@ScriptedAlchemy ScriptedAlchemy force-pushed the remove-resolve-replacements branch from f430834 to f21aca1 Compare November 17, 2024 18:47
squadronai[bot]
squadronai bot reviewed Nov 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@squadronai squadronai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental Review

Comments posted: 1

Configuration

Squadron Mode: essential

Commits Reviewed

4c9f72526b45f76ebcaea4eeb4a51434300a0940...f21aca1b4a7acd136ca6d37c61fecdda31572e10

Files Reviewed
  • packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

  • .changeset/thick-baboons-hear.md

@module-federation module-federation deleted a comment from squadronai bot Nov 17, 2024
@ScriptedAlchemy ScriptedAlchemy changed the title fix(runtime): remove resolve replacements fix(enhanced): remove resolve replacements Nov 17, 2024
@ScriptedAlchemy ScriptedAlchemy merged commit 5613265 into main Nov 17, 2024
@ScriptedAlchemy ScriptedAlchemy deleted the remove-resolve-replacements branch November 17, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@squadronai squadronai[bot] squadronai[bot] left review comments

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScriptedAlchemy