Skip to content

fix(storybook-addon): correct peerDependencies declaration#3231

Merged
nyqykk merged 2 commits intomodule-federation:mainfrom
fi3ework:storybook-peer
Nov 15, 2024
Merged

fix(storybook-addon): correct peerDependencies declaration#3231
nyqykk merged 2 commits intomodule-federation:mainfrom
fi3ework:storybook-peer

Conversation

@fi3ework
Copy link
Copy Markdown
Contributor

@fi3ework fi3ework commented Nov 15, 2024

Description

  • Mark Storybook 8 as valid peer dependencies as well.
  • Loosen peer dep version restrictions of most of the peer deps.
  • Add @rsbuild/core to peer deps.
  • Mark all peer deps as optional.
  • Run pnpm dedupe to clean the lock file.

Related Issue

rstackjs/storybook-rsbuild#30 (comment)

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 15, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 82e5657

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@module-federation/storybook-addon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 82e5657
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/673719e30dd22e0008e71b0c
😎 Deploy Preview https://deploy-preview-3231--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nyqykk
Copy link
Copy Markdown
Contributor

nyqykk commented Nov 15, 2024 •
edited
Loading

Lockfile changed too much causes CI failed, have you enable corepack? I think this is caused by pnpm version, this repo need pnpm@8.

@fi3ework
Copy link
Copy Markdown
Contributor Author

fi3ework commented Nov 15, 2024 •
edited
Loading

corepack enabled already, let me check it locally.

@nyqykk
Copy link
Copy Markdown
Contributor

nyqykk commented Nov 15, 2024 •
edited
Loading

corepack enabled already, how can I reproduce the test locally?

run pnpm test:pkg, but i think it is not caused by your code, just by lockfile, you can copy main branch lockfile and re generate lockfile

@fi3ework fi3ework closed this Nov 15, 2024
@fi3ework fi3ework reopened this Nov 15, 2024
@fi3ework fi3ework closed this Nov 15, 2024
@fi3ework fi3ework reopened this Nov 15, 2024
@fi3ework
Copy link
Copy Markdown
Contributor Author

fi3ework commented Nov 15, 2024 •
edited
Loading

Test passed after not perform pnpm dedupe, don't know why pnpm dudupe break the test.

@nyqykk nyqykk merged commit 4c9f725 into module-federation:main Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nyqykk nyqykk nyqykk approved these changes

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fi3ework @nyqykk