Skip to content

fix: patch/replace @changesets/assemble-release-plan to disable major on peer dep change#3184

Merged
zhoushaw merged 2 commits intomainfrom
disable-changeset-peermajor
Nov 6, 2024
Merged

fix: patch/replace @changesets/assemble-release-plan to disable major on peer dep change#3184
zhoushaw merged 2 commits intomainfrom
disable-changeset-peermajor

Conversation

@ScriptedAlchemy
Copy link
Copy Markdown
Member

@ScriptedAlchemy ScriptedAlchemy commented Nov 5, 2024 •
edited
Loading

Description

Patch changeset release plan generation to prevent peerDependencies changes causing a major release.

Related Issue

changesets/changesets#1011

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ea1c3bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 5, 2024 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 5936946
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/672aad29534c5d000878d852
😎 Deploy Preview https://deploy-preview-3184--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy ScriptedAlchemy force-pushed the disable-changeset-peermajor branch from b56bbe7 to ea1c3bc Compare November 5, 2024 23:42
@ScriptedAlchemy ScriptedAlchemy changed the title fix: disable major bump on peer dep change fix: patch changesets/assemble-release-plan to disable major on peer dep change Nov 5, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 5, 2024 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit ea1c3bc
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/672aad75577c4e0008d569f8
😎 Deploy Preview https://deploy-preview-3184--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ScriptedAlchemy
ScriptedAlchemy commented Nov 5, 2024
View reviewed changes
packages/assemble-release-plan/src/determine-dependents.ts
onlyUpdatePeerDependentsWhenOutOfRange: boolean;
}) {
//disable major bump due to peer dep
if (depType === 'peerDependencies') {
Copy link
Copy Markdown
Member Author

@ScriptedAlchemy ScriptedAlchemy Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this disables upgrading to major for peerDep changes. All this for 1 line of code :P
But may be useful in future as now we can define custom rules like convert any major into a minor, then use major version in changeset without it impacting semver till we are ready to go to v1 across the core libs

@ScriptedAlchemy ScriptedAlchemy changed the title fix: patch changesets/assemble-release-plan to disable major on peer dep change fix: patch/replace @changesets/assemble-release-plan to disable major on peer dep change Nov 6, 2024
@zhoushaw zhoushaw merged commit c2a63a6 into main Nov 6, 2024
@zhoushaw zhoushaw deleted the disable-changeset-peermajor branch November 6, 2024 02:32
This was referenced Nov 7, 2024
Merged
Merged
@olivermrbl olivermrbl mentioned this pull request Apr 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhoushaw zhoushaw zhoushaw approved these changes

@2heal1 2heal1 2heal1 approved these changes

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ScriptedAlchemy @zhoushaw @2heal1