fix: replace require with lazyRequire to ensure proper initialization ordering in plugins (#4557)

2heal1 · web-flow · commit 8b8da62b821e · 2026-03-17T18:44:22.000+08:00
diff --git a/.changeset/salty-doodles-sing.md b/.changeset/salty-doodles-sing.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/enhanced': patch
+---
+
+fix(enhanced): replace require with lazyRequire to ensure proper initialization ordering in plugins
diff --git a/packages/enhanced/src/wrapper/BaseWrapperPlugin.ts b/packages/enhanced/src/wrapper/BaseWrapperPlugin.ts
@@ -1,6 +1,11 @@
 import type { WebpackPluginInstance, Compiler } from 'webpack';
 import { getWebpackPath } from '@module-federation/sdk/normalize-webpack-path';
 
+// Use module.require instead of require to prevent bundlers (rolldown/tsdown) from
+// hoisting the call to the top of the file. This ensures the require only executes
+// at call time, preserving strict initialization ordering. CJS-only.
+const lazyRequire = (id: string): any => module.require(id);
+
 /**
  * Base Wrapper Plugin Class
  *
@@ -33,7 +38,7 @@ export default abstract class BaseWrapperPlugin implements WebpackPluginInstance
       process.env['FEDERATION_WEBPACK_PATH'] || getWebpackPath(compiler);
 
     // Lazily load core plugin after webpack path is set.
-    const CorePlugin = require(this.coreModulePath).default as any;
+    const CorePlugin = lazyRequire(this.coreModulePath).default as any;
 
     // Create core plugin instance and apply it
     this.createCorePluginInstance(CorePlugin, compiler);
diff --git a/packages/enhanced/src/wrapper/FederationModulesPlugin.ts b/packages/enhanced/src/wrapper/FederationModulesPlugin.ts
@@ -1,6 +1,11 @@
 import type { Compilation } from 'webpack';
 import BaseWrapperPlugin from './BaseWrapperPlugin';
 
+// Use module.require instead of require to prevent bundlers (rolldown/tsdown) from
+// hoisting the call to the top of the file. This ensures the require only executes
+// at call time, preserving strict initialization ordering. CJS-only.
+const lazyRequire = (id: string): any => module.require(id);
+
 const PLUGIN_NAME = 'FederationModulesPlugin';
 
 export default class FederationModulesPlugin extends BaseWrapperPlugin {
@@ -9,9 +14,10 @@ export default class FederationModulesPlugin extends BaseWrapperPlugin {
   }
 
   static getCompilationHooks(compilation: Compilation) {
-    const CoreFederationModulesPlugin =
-      require('../lib/container/runtime/FederationModulesPlugin')
-        .default as typeof import('../lib/container/runtime/FederationModulesPlugin').default;
+    const CoreFederationModulesPlugin = lazyRequire(
+      '../lib/container/runtime/FederationModulesPlugin',
+    )
+      .default as typeof import('../lib/container/runtime/FederationModulesPlugin').default;
     return CoreFederationModulesPlugin.getCompilationHooks(compilation);
   }
 
diff --git a/packages/enhanced/src/wrapper/ModuleFederationPlugin.ts b/packages/enhanced/src/wrapper/ModuleFederationPlugin.ts
@@ -103,8 +103,6 @@ export default class ModuleFederationPlugin extends BaseWrapperPlugin {
     if (!enableBridgePlugin && hasBridgeReact) {
       compiler.hooks.afterPlugins.tap('BridgeReactBaseAliasPlugin', () => {
         try {
-          const path = require('path');
-          const fs = require('fs');
           const bridgeReactBasePath = path.resolve(
             compiler.context,
             'node_modules/@module-federation/bridge-react/dist/base.es.js',

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@module-federation/enhanced': patch
 +---
++
 +fix(enhanced): replace require with lazyRequire to ensure proper initialization ordering in plugins