fix(rsbuild-plugin): replace direct JSON import with builder define to fix Node.js >= 22 (#4564)

2heal1 · claude · web-flow · commit 762b9ef7a06a · 2026-03-18T17:04:25.000+08:00
Co-authored-by: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/.changeset/fix-rsbuild-plugin-json-import.md b/.changeset/fix-rsbuild-plugin-json-import.md
@@ -0,0 +1,5 @@
+---
+"@module-federation/rsbuild-plugin": patch
+---
+
+fix(rsbuild-plugin): replace direct package.json import with builder define injection to avoid Node.js >= 22 compatibility error
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -24,6 +24,28 @@
         "no-extra-semi": "error"
       }
     },
+    {
+      "files": [
+        "**/src/**/*.ts",
+        "**/src/**/*.tsx",
+        "**/src/**/*.js",
+        "**/src/**/*.jsx"
+      ],
+      "excludedFiles": ["**/*.config.*", "**/*.spec.*", "**/*.test.*"],
+      "rules": {
+        "no-restricted-imports": [
+          "error",
+          {
+            "patterns": [
+              {
+                "group": ["**/*.json"],
+                "message": "Direct JSON imports may fail in Node.js >= 22. Inject values via builder define (source.define in rslib/rsbuild) instead."
+              }
+            ]
+          }
+        ]
+      }
+    },
     {
       "files": ["*.spec.ts", "*.spec.tsx", "*.spec.js", "*.spec.jsx"],
       "env": { "jest": true },
diff --git a/packages/esbuild/.eslintrc.json b/packages/esbuild/.eslintrc.json
@@ -4,7 +4,8 @@
     "!**/*",
     "**/vite.config.*.timestamp*",
     "**/vitest.config.*.timestamp*",
-    "rslib.config.ts"
+    "rslib.config.ts",
+    "dist/**"
   ],
   "overrides": [
     {
diff --git a/packages/esbuild/src/adapters/lib/commonjs.ts b/packages/esbuild/src/adapters/lib/commonjs.ts
@@ -140,6 +140,7 @@ export function commonjs({
     setup({ onLoad, esbuild, initialOptions }) {
       let esbuild_shim: typeof import('esbuild') | undefined;
       const require_esbuild = () =>
+        // eslint-disable-next-line @typescript-eslint/no-require-imports
         esbuild || (esbuild_shim ||= require('esbuild'));
       const read = promises.readFile;
       const lexer = new Lexer();
diff --git a/packages/esbuild/src/adapters/lib/manifest.ts b/packages/esbuild/src/adapters/lib/manifest.ts
@@ -1,18 +1,7 @@
 import fs from 'fs';
 import path from 'path';
 import { resolve } from './collect-exports.js';
-import {
-  BuildOptions,
-  PluginBuild,
-  Plugin,
-  OnResolveArgs,
-  OnLoadArgs,
-  BuildResult,
-  BuildContext,
-} from 'esbuild';
-//@ts-expect-error
-import { version as pluginVersion } from '@module-federation/esbuild/package.json';
-
+import { BuildResult } from 'esbuild';
 interface OutputFile {
   entryPoint?: string;
   imports?: { path: string }[];
@@ -91,6 +80,7 @@ export const writeRemoteManifest = async (config: any, result: BuildResult) => {
   try {
     const packageJsonPath =
       (await resolve(process.cwd(), '/package.json')) || '';
+    // eslint-disable-next-line @typescript-eslint/no-require-imports
     packageJson = require(packageJsonPath);
   } catch (e) {
     packageJson = { name: config.name };
@@ -261,7 +251,7 @@ export const writeRemoteManifest = async (config: any, result: BuildResult) => {
       },
       types,
       globalName: config.name,
-      pluginVersion,
+      pluginVersion: __VERSION__,
       publicPath,
     },
     shared,
diff --git a/packages/esbuild/src/adapters/lib/plugin.ts b/packages/esbuild/src/adapters/lib/plugin.ts
@@ -53,6 +53,7 @@ const cjsToEsmPlugin: Plugin = {
       async (args: OnLoadArgs) => {
         let esbuild_shim: typeof import('esbuild') | undefined;
         const require_esbuild = () =>
+          // eslint-disable-next-line @typescript-eslint/no-require-imports
           build.esbuild || (esbuild_shim ||= require('esbuild'));
 
         const packageBuilder = await require_esbuild().build({
diff --git a/packages/modernjs-v3/src/cli/configPlugin.ts b/packages/modernjs-v3/src/cli/configPlugin.ts
@@ -20,14 +20,6 @@ import type {
 } from '@modern-js/app-tools';
 import type { BundlerChainConfig } from '../interfaces/bundler';
 
-declare global {
-  namespace NodeJS {
-    interface ProcessEnv {
-      IS_ESM_BUILD?: string;
-    }
-  }
-}
-
 const defaultPath = path.resolve(process.cwd(), 'module-federation.config.ts');
 
 export type ConfigType = Rspack.Configuration;
@@ -56,7 +48,9 @@ const resolvePackageFile = (
   return require.resolve(
     path.join(
       packageRoot,
-      process.env.IS_ESM_BUILD === 'true' ? esmRelativePath : cjsRelativePath,
+      process.env['IS_ESM_BUILD'] === 'true'
+        ? esmRelativePath
+        : cjsRelativePath,
     ),
   );
 };
@@ -103,6 +97,7 @@ export const getMFConfig = async (
     return config;
   }
   const mfConfigPath = configPath ? configPath : defaultPath;
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const { createJiti } = require('jiti');
   const jit = createJiti(__filename, {
     interopDefault: true,
@@ -327,7 +322,6 @@ export function patchBundlerConfig(options: {
 
   const splitChunkConfig = chain.optimization.splitChunks.entries();
   if (!isServer) {
-    // @ts-ignore type not the same
     autoDeleteSplitChunkCacheGroups(mfConfig, splitChunkConfig);
   }
 
diff --git a/packages/modernjs-v3/src/cli/server/data-fetch-server-plugin.ts b/packages/modernjs-v3/src/cli/server/data-fetch-server-plugin.ts
@@ -9,7 +9,6 @@ const dataFetchServePlugin = (): ServerPlugin => ({
       const { middlewares } = api.getServerContext();
       middlewares.push({
         name: 'module-federation-serve-manifest',
-        // @ts-ignore type error
         handler: dataFetchMiddleWare,
       });
     });
diff --git a/packages/modernjs-v3/src/cli/ssrPlugin.ts b/packages/modernjs-v3/src/cli/ssrPlugin.ts
@@ -301,7 +301,6 @@ export const moduleFederationSSRPlugin = (
         });
       }
     });
-    // @ts-ignore
     api.config(() => {
       return {
         builderPlugins: [mfSSRRsbuildPlugin(pluginOptions)],
diff --git a/packages/modernjs/src/cli/configPlugin.ts b/packages/modernjs/src/cli/configPlugin.ts
@@ -22,14 +22,6 @@ import type {
 } from '@modern-js/app-tools';
 import type { BundlerChainConfig } from '../interfaces/bundler';
 
-declare global {
-  namespace NodeJS {
-    interface ProcessEnv {
-      IS_ESM_BUILD?: string;
-    }
-  }
-}
-
 const defaultPath = path.resolve(process.cwd(), 'module-federation.config.ts');
 
 export type ConfigType<T> = T extends 'webpack'
@@ -62,7 +54,9 @@ const resolvePackageFile = (
   return require.resolve(
     path.join(
       packageRoot,
-      process.env.IS_ESM_BUILD === 'true' ? esmRelativePath : cjsRelativePath,
+      process.env['IS_ESM_BUILD'] === 'true'
+        ? esmRelativePath
+        : cjsRelativePath,
     ),
   );
 };
@@ -109,6 +103,7 @@ export const getMFConfig = async (
     return config;
   }
   const mfConfigPath = configPath ? configPath : defaultPath;
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const { createJiti } = require('jiti');
   const jit = createJiti(__filename, {
     interopDefault: true,
@@ -333,7 +328,7 @@ export function patchBundlerConfig(options: {
 
   const splitChunkConfig = chain.optimization.splitChunks.entries();
   if (!isServer) {
-    // @ts-ignore type not the same
+    // @ts-expect-error type not the same
     autoDeleteSplitChunkCacheGroups(mfConfig, splitChunkConfig);
   }
 
diff --git a/packages/modernjs/src/cli/server/data-fetch-server-plugin.ts b/packages/modernjs/src/cli/server/data-fetch-server-plugin.ts
@@ -9,7 +9,7 @@ const dataFetchServePlugin = (): ServerPlugin => ({
       const { middlewares } = api.getServerContext();
       middlewares.push({
         name: 'module-federation-serve-manifest',
-        // @ts-ignore type error
+        // @ts-expect-error type error
         handler: dataFetchMiddleWare,
       });
     });
diff --git a/packages/native-federation-typescript/src/lib/typeScriptCompiler.ts b/packages/native-federation-typescript/src/lib/typeScriptCompiler.ts
@@ -104,6 +104,7 @@ const createHost = (
 const createVueTscProgram = (
   programOptions: typescript.CreateProgramOptions,
 ) => {
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const vueTypescript = require('vue-tsc');
   return vueTypescript.createProgram(programOptions);
 };
diff --git a/packages/rsbuild-plugin/rslib.config.ts b/packages/rsbuild-plugin/rslib.config.ts
@@ -1,5 +1,11 @@
 import { pluginPublint } from 'rsbuild-plugin-publint';
 import { defineConfig } from '@rslib/core';
+import { readFileSync } from 'fs';
+import { resolve } from 'path';
+
+const pkg = JSON.parse(
+  readFileSync(resolve(__dirname, './package.json'), 'utf-8'),
+);
 
 export default defineConfig({
   plugins: [pluginPublint()],
@@ -31,6 +37,9 @@ export default defineConfig({
       ],
     },
     tsconfigPath: './tsconfig.lib.json',
+    define: {
+      __RSBUILD_PLUGIN_PACKAGE_NAME__: JSON.stringify(pkg.name),
+    },
   },
   output: {
     target: 'node',
diff --git a/packages/rsbuild-plugin/src/cli/index.ts b/packages/rsbuild-plugin/src/cli/index.ts
@@ -5,7 +5,6 @@ import {
   PLUGIN_NAME,
 } from '@module-federation/enhanced/rspack';
 import { isRequiredVersion, getManifestFileName } from '@module-federation/sdk';
-import pkgJson from '../../package.json';
 import logger from '../logger';
 import {
   isRegExp,
@@ -474,7 +473,7 @@ export const pluginModuleFederation = (
                 const match = shared.some((dep) => {
                   if (
                     (ext as RegExp).test(dep) ||
-                    (ext as RegExp).test(pkgJson.name)
+                    (ext as RegExp).test(__RSBUILD_PLUGIN_PACKAGE_NAME__)
                   ) {
                     sharedModule = dep;
                     return true;
@@ -487,7 +486,7 @@ export const pluginModuleFederation = (
               }
 
               if (typeof ext === 'string') {
-                if (ext === pkgJson.name) {
+                if (ext === __RSBUILD_PLUGIN_PACKAGE_NAME__) {
                   return false;
                 }
 
diff --git a/packages/rsbuild-plugin/src/env.d.ts b/packages/rsbuild-plugin/src/env.d.ts
@@ -0,0 +1,2 @@
+/** Injected at build time by rslib define — the package name of this plugin. */
+declare const __RSBUILD_PLUGIN_PACKAGE_NAME__: string;
diff --git a/packages/runtime-tools/.eslintrc.json b/packages/runtime-tools/.eslintrc.json
@@ -1,6 +1,6 @@
 {
   "extends": ["../../.eslintrc.json"],
-  "ignorePatterns": ["!**/*"],
+  "ignorePatterns": ["!**/*", "dist/**"],
   "overrides": [
     {
       "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
diff --git a/packages/third-party-dts-extractor/src/ThirdPartyExtractor.ts b/packages/third-party-dts-extractor/src/ThirdPartyExtractor.ts
@@ -106,6 +106,7 @@ class ThirdPartyExtractor {
         this.addPkgs(typedPkgName, typedDir);
         return typedDir;
       }
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
     } catch (_err) {
       return;
     }
diff --git a/packages/treeshake-frontend/adapter/index.ts b/packages/treeshake-frontend/adapter/index.ts
@@ -3,6 +3,7 @@ import path from 'node:path';
 
 export type FrontendAdapter = {
   id: string;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   register: (app: { get: (path: string, handler: any) => void }) => void;
 };
 
@@ -59,6 +60,7 @@ export function createTreeshakeFrontendAdapter(
   const indexFile = opts.indexFile ?? 'index.html';
   const spaFallback = opts.spaFallback ?? true;
 
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const handler = async (c: any) => {
     let requestPath = c.req.path;
     try {
diff --git a/packages/typescript/src/lib/TypescriptCompiler.ts b/packages/typescript/src/lib/TypescriptCompiler.ts
@@ -17,6 +17,7 @@ import { Logger } from '../Logger';
 
 let vueTs: typeof VueTs;
 try {
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   vueTs = require('vue-tsc');
 } catch {
   // vue-tsc is an optional dependency.

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@module-federation/rsbuild-plugin": patch
 +---
++
 +fix(rsbuild-plugin): replace direct package.json import with builder define injection to avoid Node.js >= 22 compatibility error
Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,6 @@ export const moduleFederationSSRPlugin = (`
`301`	`301`	`});`
`302`	`302`	`}`
`303`	`303`	`});`
`304`		`- // @ts-ignore`
`305`	`304`	`api.config(() => {`
`306`	`305`	`return {`
`307`	`306`	`builderPlugins: [mfSSRRsbuildPlugin(pluginOptions)],`