fix(rsbuild-plugin): remove duplicate logs for shared modules (#3187)

KyrieLii · web-flow · commit 5fc6045a328c · 2024-11-07T10:52:35.000+08:00
diff --git a/.changeset/olive-meals-applaud.md b/.changeset/olive-meals-applaud.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/rsbuild-plugin': patch
+---
+
+fix(rsbuild-plugin): remove duplicate logs for shared modules.
diff --git a/packages/rsbuild-plugin/src/cli/index.ts b/packages/rsbuild-plugin/src/cli/index.ts
@@ -92,6 +92,7 @@ export const pluginModuleFederation = (
       // filter external with shared config,
       const externals = config.output.externals;
       if (Array.isArray(externals)) {
+        const sharedModules = new Set<string>();
         config.output.externals = externals.filter((ext) => {
           let sharedModule;
           if (isRegExp(ext)) {
@@ -106,11 +107,7 @@ export const pluginModuleFederation = (
               return false;
             });
 
-            if (match) {
-              logger.log(
-                `${sharedModule} is removed from externals because it is a shared module.`,
-              );
-            }
+            match && sharedModule && sharedModules.add(sharedModule);
             return !match;
           }
 
@@ -126,15 +123,20 @@ export const pluginModuleFederation = (
               return dep === ext;
             });
             if (match) {
-              logger.log(
-                `${sharedModule} is removed from externals because it is a shared module.`,
-              );
+              sharedModule && sharedModules.add(sharedModule);
               return false;
             }
             return true;
           }
           return true;
         });
+        if (sharedModules.size > 0) {
+          for (const sharedModule of sharedModules) {
+            logger.log(
+              `${sharedModule} is removed from externals because it is a shared module.`,
+            );
+          }
+        }
       }
 
       const mfConfig: EnvironmentConfig = {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@module-federation/rsbuild-plugin': patch
 +---
++
 +fix(rsbuild-plugin): remove duplicate logs for shared modules.