WIP: fix(dts-plugin): add dynamic-remote-type-hints-plugin to runtimePlugins if not disable (#3758)

2heal1 · web-flow · commit 0eb66977c339 · 2025-05-15T14:39:39.000+08:00
diff --git a/.changeset/quiet-bottles-unite.md b/.changeset/quiet-bottles-unite.md
@@ -0,0 +1,7 @@
+---
+'@module-federation/dts-plugin': patch
+'@module-federation/enhanced': patch
+'@module-federation/rspack': patch
+---
+
+fix(dts-plugin): add dynamic-remote-type-hints-plugin to runtimePlugins if not disable
diff --git a/packages/dts-plugin/src/plugins/DtsPlugin.ts b/packages/dts-plugin/src/plugins/DtsPlugin.ts
@@ -37,15 +37,15 @@ export const normalizeDtsOptions = (
 
 export class DtsPlugin implements WebpackPluginInstance {
   options: moduleFederationPlugin.ModuleFederationPluginOptions;
+  clonedOptions: moduleFederationPlugin.ModuleFederationPluginOptions;
   constructor(options: moduleFederationPlugin.ModuleFederationPluginOptions) {
     this.options = options;
+    // Create a shallow clone of the options object to avoid mutating the original
+    this.clonedOptions = { ...options };
   }
 
   apply(compiler: Compiler) {
-    const { options } = this;
-
-    // Create a shallow clone of the options object to avoid mutating the original
-    const clonedOptions = { ...options };
+    const { options, clonedOptions } = this;
 
     // Clean up query parameters in exposes paths without mutating original
     if (options.exposes && typeof options.exposes === 'object') {
@@ -106,4 +106,18 @@ export class DtsPlugin implements WebpackPluginInstance {
       fetchRemoteTypeUrlsResolve,
     ).apply(compiler);
   }
+
+  addRuntimePlugins() {
+    const { options, clonedOptions } = this;
+    if (!clonedOptions.runtimePlugins) {
+      return;
+    }
+    if (!options.runtimePlugins) {
+      options.runtimePlugins = [];
+    }
+    clonedOptions.runtimePlugins.forEach((plugin) => {
+      options.runtimePlugins.includes(plugin) ||
+        options.runtimePlugins.push(plugin);
+    });
+  }
 }
diff --git a/packages/enhanced/src/lib/container/ModuleFederationPlugin.ts b/packages/enhanced/src/lib/container/ModuleFederationPlugin.ts
@@ -114,7 +114,9 @@ class ModuleFederationPlugin implements WebpackPluginInstance {
     }
 
     if (options.dts !== false) {
-      new DtsPlugin(options).apply(compiler);
+      const dtsPlugin = new DtsPlugin(options);
+      dtsPlugin.apply(compiler);
+      dtsPlugin.addRuntimePlugins();
     }
     if (options.dataPrefetch) {
       new PrefetchPlugin(options).apply(compiler);
diff --git a/packages/rspack/src/ModuleFederationPlugin.ts b/packages/rspack/src/ModuleFederationPlugin.ts
@@ -114,8 +114,10 @@ export class ModuleFederationPlugin implements RspackPluginInstance {
     let disableDts = options.dts === false;
 
     if (!disableDts) {
+      const dtsPlugin = new DtsPlugin(options);
       // @ts-ignore
-      new DtsPlugin(options).apply(compiler);
+      dtsPlugin.apply(compiler);
+      dtsPlugin.addRuntimePlugins();
     }
     if (!disableManifest && options.exposes) {
       try {

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,9 @@ class ModuleFederationPlugin implements WebpackPluginInstance {`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`if (options.dts !== false) {`
`117`		`- new DtsPlugin(options).apply(compiler);`
	`117`	`+ const dtsPlugin = new DtsPlugin(options);`
	`118`	`+ dtsPlugin.apply(compiler);`
	`119`	`+ dtsPlugin.addRuntimePlugins();`
`118`	`120`	`}`
`119`	`121`	`if (options.dataPrefetch) {`
`120`	`122`	`new PrefetchPlugin(options).apply(compiler);`