Skip to content

fix(ci): use deploy/go.mod for deploy workflow Go version and bump root Go to 1.25.8#1040

Merged
tadasant merged 1 commit intomainfrom
fix/deploy-go-version
Mar 6, 2026
Merged

fix(ci): use deploy/go.mod for deploy workflow Go version and bump root Go to 1.25.8#1040
tadasant merged 1 commit intomainfrom
fix/deploy-go-version

Conversation

@tadasant
Copy link
Copy Markdown
Member

@tadasant tadasant commented Mar 6, 2026

Summary

Fixes two CI issues:

1. Deploy workflows broken since PR #1034 (all staging deploys failing)

The deploy-staging and deploy-production workflows install Go using the root go.mod, but then build Pulumi infrastructure code from the deploy/ directory which has its own go.mod.

This started failing when PR #1034 (build(deps): bump github.com/pulumi/pulumi/sdk/v3 from 3.220.0 to 3.225.1 in /deploy) bumped deploy/go.mod from Go 1.24.11 to Go 1.25.6 — a version newer than the root module's Go 1.24.13. Every staging deploy since that merge (Mar 6) has failed with:

go: go.mod requires go >= 1.25.6 (running go 1.24.13; GOTOOLCHAIN=local)

The last successful deploy was commit cb4807a on Mar 1, before the Go version bump.

Fix: point go-version-file in both deploy workflows at deploy/go.mod instead of the root go.mod.

2. govulncheck failing due to Go stdlib vulnerabilities

Five new Go stdlib vulnerabilities (GO-2026-4599 through GO-2026-4603) were published on Mar 5-6 affecting Go 1.24.13, fixed in Go 1.25.8. These cause govulncheck in the CI pipeline to fail.

Fix: bump root go.mod from Go 1.24.13 to Go 1.25.8.

Test plan

  • CI pipeline passes (govulncheck, build, lint, tests)
  • Verify the deploy-staging workflow passes on the next push to main after merge

🤖 Generated with Claude Code

…ot Go to 1.25.8

The deploy jobs install Go based on the root go.mod (Go 1.24.13), but
then build Pulumi code from deploy/ which requires Go 1.25.6. This
causes all staging deploys to fail with:

  go: go.mod requires go >= 1.25.6 (running go 1.24.13; GOTOOLCHAIN=local)

Point the deploy jobs at deploy/go.mod so the correct Go version is
installed.

Also bump the root go.mod from Go 1.24.13 to 1.25.8 to resolve 5
stdlib vulnerabilities (GO-2026-4599 through GO-2026-4603) that cause
govulncheck to fail in CI.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tadasant tadasant force-pushed the fix/deploy-go-version branch from b3ad5cc to 90850c9 Compare March 6, 2026 21:58
@tadasant tadasant changed the title fix(ci): use deploy/go.mod for deploy workflow Go version fix(ci): use deploy/go.mod for deploy workflow Go version and bump root Go to 1.25.8 Mar 6, 2026
@tadasant tadasant requested a review from a team March 6, 2026 22:03
@tadasant tadasant merged commit 7462b3c into main Mar 6, 2026
6 checks passed
@tadasant tadasant deleted the fix/deploy-go-version branch March 6, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants