Fixes #3237: Fix NullPointerException in Only.verify#3349
Merged
TimvdLippe merged 1 commit intomockito:mainfrom May 24, 2024
Merged
Fixes #3237: Fix NullPointerException in Only.verify#3349TimvdLippe merged 1 commit intomockito:mainfrom
TimvdLippe merged 1 commit intomockito:mainfrom
Conversation
059f448 to
c0184d8
Compare
TimvdLippe
approved these changes
May 24, 2024
Contributor
TimvdLippe
left a comment
There was a problem hiding this comment.
Thanks for the fix and regression test!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3349 +/- ##
=========================================
Coverage 85.35% 85.36%
- Complexity 2926 2927 +1
=========================================
Files 336 336
Lines 8907 8908 +1
Branches 1109 1110 +1
=========================================
+ Hits 7603 7604 +1
Misses 1013 1013
Partials 291 291 ☔ View full report in Codecov by Sentry. |
…rified invocation This resolves the issue where Only.verify throws a NullPointerException when no unverified invocations are found.
c0184d8 to
4dcd1b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the latest version of mockito-core (5.9.0), the
Only.verifymethod throws aNullPointerExceptionwhen it attempts to callReporter.noMoreInteractionsWantedwith a null argument. This occurs because the methodInvocationsFinder.findFirstUnverifiedcan return null, but this is not handled properly inOnly.verify.This fixes #3237
Changes
InvocationsFinder.findFirstUnverifiedinOnly.verify. If the result is null,Reporter.noMoreInteractionsWantedis not called.Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant