Fixes some mistakes and missing details in documentation#2889
Merged
Conversation
- Makes static mock verification and construction initialisers into functional interfaces, and adds some missing documentation notes. - Fixes a number of grammar/spelling typos. - Replaces an instance of a JavaDoc comment suggesting to use a deprecated method with a reference to the suggested replacement. - Adds a note about supporting chaining of Spy with InjectMocks into the InjectMocks documentation
9c807de to
ef50622
Compare
Codecov ReportBase: 85.81% // Head: 85.81% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
=========================================
Coverage 85.81% 85.81%
Complexity 2844 2844
=========================================
Files 324 324
Lines 8601 8601
Branches 1059 1059
=========================================
Hits 7381 7381
Misses 947 947
Partials 273 273
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TimvdLippe
approved these changes
Jan 29, 2023
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Awesome work. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
functional interfaces, and adds some missing documentation notes.
Since Java 8 is the minimum target, this seems reasonable to
include.
deprecated method with a reference to the suggested replacement.
the InjectMocks documentation.